_redirects file not working? #234

Andre601 commented 2023年07月19日 21:48:31 +02:00

I've added a _redirects file to my pages repository containing the following content:

/AdvancedServerList/* https://docs.andre601.ch/AdvancedServerList/:splat
/Discord-Links https://docs.andre601.ch/Discord-Links
/GitHub-Markdown https://docs.andre601.ch/GitHub-Markdown
/Expansion-Wiki-Generator https://papi.andre601.ch

Yet, no matter which of the paths I access, the redirects do not happen at all. No matter if it is the one with a splat or those with a static path...

The domains themself do exist and resolve to actual sites, so this seems to be an issue with Codeberg pages.

Is there a delay until redirects become active? I've waited 15 minutes so far and no change happened. Also removed any cookies and cached data in case those could be the issue.

I've added a `_redirects` file to my `pages` repository containing the following content: ``` /AdvancedServerList/* https://docs.andre601.ch/AdvancedServerList/:splat /Discord-Links https://docs.andre601.ch/Discord-Links /GitHub-Markdown https://docs.andre601.ch/GitHub-Markdown /Expansion-Wiki-Generator https://papi.andre601.ch ``` Yet, no matter which of the paths I access, the redirects do not happen at all. No matter if it is the one with a splat or those with a static path... The domains themself do exist and resolve to actual sites, so this seems to be an issue with Codeberg pages. Is there a delay until redirects become active? I've waited 15 minutes so far and no change happened. Also removed any cookies and cached data in case those could be the issue.

Gusted commented 2023年07月19日 22:58:03 +02:00

As far as I'm aware codeberg.page hasn't yet deployed the version which has the redirect implementation. CC @6543

As far as I'm aware codeberg.page hasn't yet deployed the version which has the redirect implementation. CC @6543

Andre601 commented 2023年07月19日 23:12:05 +02:00

That's strange given the docs already mention it, so if that's true, then the docs may need to pull that page to stop people from being mislead...

Although, in such a case would I now shamelessly point to my issue #232 which suggests a .pages file to be used for multiple new features, including the move of _redirects to it as a dedicated option...
May be a good idea (if technically possible of course) to maybe consider this before deploying the _redirects file support.

---

EDIT

I for now added a Cloudflare redirect rule for the /AdvancedServerList/* paths.
So if you want to test if it works or not, use one of the other entries as the above won't be a reliable source to test.

That's strange given the docs already mention it, so if that's true, then the docs may need to pull that page to stop people from being mislead... Although, in such a case would I now shamelessly point to my issue #232 which suggests a `.pages` file to be used for multiple new features, including the move of `_redirects` to it as a dedicated option... May be a good idea (if technically possible of course) to maybe consider this before deploying the `_redirects` file support. --- EDIT I for now added a Cloudflare redirect rule for the `/AdvancedServerList/*` paths. So if you want to test if it works or not, use one of the other entries as the above won't be a reliable source to test.

Gusted commented 2023年07月20日 16:21:47 +02:00

I've just checked, production is running ce241fa40a, which didn't yet include the redirect code. @6543 I think it might be time for a new release, because apparently the documentation was already updated.

I've just checked, production is running https://codeberg.org/Codeberg/pages-server/commit/ce241fa40adee2b12f8e225db98e09a45bc2acbb, which didn't yet include the redirect code. @6543 I think it might be time for a new release, because apparently [the documentation](https://docs.codeberg.org/codeberg-pages/redirects/) was already updated.

Gusted commented 2023年07月20日 16:23:19 +02:00

Although, in such a case would I now shamelessly point to my issue #232 which suggests a .pages file to be used for multiple new features, including the move of _redirects to it as a dedicated option...
May be a good idea (if technically possible of course) to maybe consider this before deploying the _redirects file support.

That would include quite a lot more code and thought before it can actually be implemented.

> Although, in such a case would I now shamelessly point to my issue #232 which suggests a .pages file to be used for multiple new features, including the move of _redirects to it as a dedicated option... May be a good idea (if technically possible of course) to maybe consider this before deploying the _redirects file support. That would include quite a lot more code and thought before it can actually be implemented.

Andre601 commented 2023年07月20日 17:46:11 +02:00

That would include quite a lot more code and thought before it can actually be implemented.

Most likely yeah. Tho then the _redirects feature could be properly delayed with notes on the docs instead of pushing it now only to later be scrapped (if that would be the case, which I honestly would encourage as a single file would reduce extra configuration management for end users).

Currently considering to push a PR to docs repo to add a note about the redirect status (Not yet being implemented in production of Codeberg Pages), tho I first ask here...

Not sure how long the process of making a release would take here and if that note would be worth it.

> That would include quite a lot more code and thought before it can actually be implemented. Most likely yeah. Tho then the `_redirects` feature could be properly delayed with notes on the docs instead of pushing it now only to later be scrapped (if that would be the case, which I honestly would encourage as a single file would reduce extra configuration management for end users). Currently considering to push a PR to docs repo to add a note about the redirect status (Not yet being implemented in production of Codeberg Pages), tho I first ask here... Not sure how long the process of making a release would take here and if that note would be worth it.

tionis commented 2023年07月20日 18:08:46 +02:00

One point to consider is that the _redirects file is also supported by some other static site hosting platforms and as such would allow automatic compatibility for redirects with other servers.
I know of following hosts that support it:

• IPFS (the kubo implementation at least claims to support it)
• cloudflare

One point to consider is that the `_redirects` file is also supported by some other static site hosting platforms and as such would allow automatic compatibility for redirects with other servers. I know of following hosts that support it: - IPFS (the kubo implementation at least claims to support it) - cloudflare

Gusted commented 2023年07月20日 20:49:54 +02:00

Currently considering to push a PR to docs repo to add a note about the redirect status (Not yet being implemented in production of Codeberg Pages), tho I first ask here...

Feel free to create such PR.

> Currently considering to push a PR to docs repo to add a note about the redirect status (Not yet being implemented in production of Codeberg Pages), tho I first ask here... Feel free to create such PR.

Andre601 commented 2023年07月30日 15:08:40 +02:00

I really hope that an update will be made eventually, as I really need it.

Cannot use redirect rules for Cloudflare due to not proxying the DNS entries and I also don't want to make countless pages that perform a redirect...

I really hope that an update will be made eventually, as I really need it. Cannot use redirect rules for Cloudflare due to not proxying the DNS entries and I also don't want to make countless pages that perform a redirect...

Lumaeris commented 2023年08月29日 18:53:48 +02:00

Any updates?

Any updates?

lhinderberger commented 2023年08月29日 18:57:05 +02:00

The core redirection logic has been revised as part of #240 and unit tests are passing, but it will take a bit of time until all things are sorted out and ready to merge.

The core redirection logic has been revised as part of https://codeberg.org/Codeberg/pages-server/issues/240 and unit tests are passing, but it will take a bit of time until all things are sorted out and ready to merge.

crapStone commented 2023年11月15日 21:19:48 +01:00

deployed

deployed

lhinderberger commented 2023年11月15日 21:26:48 +01:00

@crapStone What has been deployed?

@crapStone What has been deployed?

crapStone commented 2023年11月15日 21:29:42 +01:00

the redirects feature was implemented a long time ago but no one created a release so Codeberg was running an old version of the pages-server

the redirects feature was implemented a long time ago but no one created a release so Codeberg was running an old version of the pages-server

Andre601 commented 2023年11月15日 22:08:19 +01:00

deployed

Awesome. Thanks!

> deployed Awesome. Thanks!

Andre601 commented 2023年11月15日 22:11:54 +01:00

Hmm... I noticed an interesting behaviour...

I have /AdvancedServerList/* https://docs.andre601.ch/AdvancedServerList/:splat defined.

But the redirect mixes up slashes it seems...

If I f.e. access https://andre601.ch/AdvancedServerList/commands/ will this redirect to https://docs.andre601.ch/AdvancedServerList//commands
The page loads... But the double slash is weird... I assume I remove the / before the :splash

Hmm... I noticed an interesting behaviour... I have `/AdvancedServerList/* https://docs.andre601.ch/AdvancedServerList/:splat` defined. But the redirect mixes up slashes it seems... If I f.e. access `https://andre601.ch/AdvancedServerList/commands/` will this redirect to `https://docs.andre601.ch/AdvancedServerList//commands` The page loads... But the double slash is weird... I assume I remove the `/` before the `:splash`