Routing all paths to index.html #120

dorianim commented 2022年07月28日 08:46:43 +02:00

Hi!

I recently deployed a react app using codeberg pages. It works fine until you refresh the page at a path other than /. In that case, you get the 404 error page from codeberg.
The reason for that is, that all requests should be routed to index.html to let react handle the routing.

Of course, this not only affects react but all major javascript frameworks.

Maybe it would be possible to always try routing to the index.html in root when a path is not found in the repo?

What do you think?

Hi! I recently deployed a react app using codeberg pages. It works fine until you refresh the page at a path other than `/`. In that case, you get the 404 error page from codeberg. The reason for that is, that all requests should be routed to index.html to let react handle the routing. Of course, this not only affects react but all major javascript frameworks. Maybe it would be possible to always try routing to the index.html in root when a path is not found in the repo? What do you think?

fnetX commented 2022年07月28日 10:22:39 +02:00

If a path is not found, it return an error 404 by the HTTP spec. Otherwise, search engines will index everything twice and broken links will remain live forever.

Just because "modern web apps" break with the basics doesn't mean that we should do that, too.
And by the way, many other "major javascript frameworks" use a path prefixed with #, e.g. /#/foo/bar. This solves the issue and is compliant with the specs.

We serve the 404.html with error code 404 by default. You can try to use this as a workaround.

If a path is not found, it return an error 404 by the HTTP spec. Otherwise, search engines will index everything twice and broken links will remain live forever. Just because "modern web apps" break with the basics doesn't mean that we should do that, too. And by the way, many other "major javascript frameworks" use a path prefixed with #, e.g. `/#/foo/bar`. This solves the issue and is compliant with the specs. We serve the 404.html with error code 404 by default. You can try to use this as a workaround.

dorianim commented 2022年07月28日 15:05:08 +02:00

Using the hash part is really smart, thank you :)

Using the hash part is really smart, thank you :)