With details and screenshots.
Codeberg/Documentation
Explain HTTP push when using 2FA #97
Merged
lhinderberger
merged 4 commits from 2020年10月16日 14:03:21 +02:00
ivan-paleo/Documentation:2fa into master
ivan-paleo
commented 2020年10月14日 16:35:54 +02:00
With details and screenshots.
lhinderberger
added the 2020年10月14日 18:34:35 +02:00
Kind: Documentation
Status: Review
labels
lhinderberger
requested changes 2020年10月14日 22:59:03 +02:00
lhinderberger
left a comment
Thank you for the PR - it's very well done! :) 👍
I only have one minor suggestion, please see below:
Thank you for the PR - it's very well done! :) 👍
I only have one minor suggestion, please see below:
content/security/2fa.md
Outdated
@ -68,0 +78,4 @@
When asked for your password, just supply the token.
You can create as many token as you like: one for each computer, one for each Git client, one for each session... you decide! You can also revoke tokens at any time by pressing the red `Delete` next to the token (see previous screenshot).
lhinderberger
commented 2020年10月14日 22:56:26 +02:00
I recommend to remove the claim that these access tokens are safer than passwords.
I recommend to remove the claim that these access tokens are safer than passwords.
ivan-paleo marked this conversation as resolved
ivan-paleo
commented 2020年10月15日 10:52:21 +02:00
Thank you for the feedback; it should be fixed now!
Thank you for the feedback; it should be fixed now!
n
approved these changes 2020年10月16日 13:24:27 +02:00
n
left a comment
Looks good to me!
One suggestion: this part of the 2FA article could be linked to from the HTTP push article.
Looks good to me!
One suggestion: this part of the 2FA article could be linked to from the HTTP push article.
ivan-paleo
commented 2020年10月16日 13:59:37 +02:00
Thanks @n for the review. I have added the link to the article in the latest commit.
Thanks @n for the review. I have added the link to the article in the latest commit.
lhinderberger
approved these changes 2020年10月16日 14:02:49 +02:00
lhinderberger
left a comment
Thank you for the PR :) Merging time 😎 🚀
Thank you for the PR :) Merging time :sunglasses: 🚀
lhinderberger
changed title from (削除) WIP: Explain HTTP push when using 2FA (削除ここまで) to Explain HTTP push when using 2FA 2020年10月16日 14:03:12 +02:00
lhinderberger
referenced this pull request from a commit 2020年10月16日 14:03:21 +02:00
lhinderberger
merged commit e9feace995 into master 2020年10月16日 14:03:21 +02:00
lhinderberger
commented 2020年10月16日 14:04:06 +02:00
Merged and deployed to live :)
Merged and deployed to live :)
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Issues affecting Codeberg Pages
Issues related to using and reading docs.codeberg.org
This is related to the generation of the documentation, not to the content itself
The priority is high
The priority is low
The priority is medium
Something has been confirmed
Something exists already
Something was marked as invalid
Something won't be fixed
Contributions are welcome!
Work is in progress
Feedback is needed
Work is completed
Review is in progress / Reviewers wanted
Codeberg Pages
Issues affecting Codeberg Pages
Documentation Usability
Issues related to using and reading docs.codeberg.org
Forgejo
Good First Issue! 👋
Kind: Bug
Kind: Documentation
Kind: Enhancement
Kind: Feature
Kind: Question
Kind: Security
Licensing
Part: Generator
This is related to the generation of the documentation, not to the content itself
Priority: High
The priority is high
Priority: Low
The priority is low
Priority: Medium
The priority is medium
Reviewed: Confirmed
Something has been confirmed
Reviewed: Duplicate
Something exists already
Reviewed: Invalid
Something was marked as invalid
Reviewed: Wontfix
Something won't be fixed
Status: Blocked
Status: Help wanted
Contributions are welcome!
Status: In progress
Work is in progress
Status: Needs feedback
Feedback is needed
Status: Ready for Review
Work is completed
Status: Review
Review is in progress / Reviewers wanted
Status: Stale
No labels
Codeberg Pages
Documentation Usability
Forgejo
Good First Issue! 👋
Kind: Bug
Kind: Documentation
Kind: Enhancement
Kind: Feature
Kind: Question
Kind: Security
Licensing
Part: Generator
Priority: High
Priority: Low
Priority: Medium
Reviewed: Confirmed
Reviewed: Duplicate
Reviewed: Invalid
Reviewed: Wontfix
Status: Blocked
Status: Help wanted
Status: In progress
Status: Needs feedback
Status: Ready for Review
Status: Review
Status: Stale
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
Codeberg/Documentation!97
Loading...
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ivan-paleo/Documentation:2fa"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?