Codeberg/Documentation
42
199
Fork
You've already forked Documentation
161

Fixing broken links #267

Merged
fnetX merged 2 commits from fsologureng/Documentation:fix_broken_links into main 2022年10月03日 21:35:02 +02:00
Contributor
Copy link

Changes:

  • Fallback images links are all lowercase now.
  • Fix html redirect (meta tag http-equiv redirect) from /git/clone-commit-via-http to /git/clone-commit-via-web.
  • Added protocol to an email link.
  • Fix some pages links.

To detect broken links I used wget:

wget --spider --recursive --level=0 --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | grep ^Found\ [0-9]*\ broken\ link

However, wget detects html redirects (meta tag http-equiv refresh) as false positive.

If broken links have found, then the referer header will be searched for find out where they are:

wget --spider --recursive --level=0 --save-headers --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | less
Changes: * Fallback images links are all lowercase now. * Fix html redirect (meta tag http-equiv redirect) from ```/git/clone-commit-via-http ```to ```/git/clone-commit-via-web```. * Added protocol to an email link. * Fix some pages links. To detect broken links I used wget: ``` wget --spider --recursive --level=0 --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | grep ^Found\ [0-9]*\ broken\ link ``` However, wget detects html redirects (meta tag http-equiv refresh) as false positive. If broken links have found, then the referer header will be searched for find out where they are: ``` wget --spider --recursive --level=0 --save-headers --debug -e robots=off --base=http://localhost:8080 http://localhost:8080 2>&1 | less ```
* Fallback images are all lowercase now.
 * Html redirect (meta tag http-equiv redirect) from /git/clone-commit-via-http to /git/clone-commit-via-web.
 * Added protocol to an email link.
 * Some pages links.
fnetX left a comment
Copy link

Are the changes for article links from .md to / intended?

Are the changes for article links from `.md` to `/` intended?
@ -17,3 +17,3 @@
## Email
For user support on Codeberg.org that *can not be handled by the channels mentioned above* (e.g. because it requires sensitive information), you can send an email to [help@codeberg.org](help-PLEASE-REMOVE-THIS-FOR-SPAM-PROTECTION@codeberg.org).
For user support on Codeberg.org that *can not be handled by the channels mentioned above* (e.g. because it requires sensitive information), you can send an email to [help@codeberg.org](mailto:help-PLEASE-REMOVE-THIS-FOR-SPAM-PROTECTION@codeberg.org).
Owner
Copy link

Is the removal of the line break (double space in md) intended?

Is the removal of the line break (double space in md) intended?
Author
Contributor
Copy link

Is the removal of the line break (double space in md) intended?

Sorry, no. I'll revert it.

I was learning Markdown when I found these broken links, so now I learned some more ;)

> Is the removal of the line break (double space in md) intended? Sorry, no. I'll revert it. I was learning Markdown when I found these broken links, so now I learned some more ;)
fnetX marked this conversation as resolved
@ -7,3 +7,3 @@
redirects:
- {"from": "/git/clone-commit-via-ssh/", "to": "/git/clone-commit-via-cli/"}
- {"from": "/git/clone-commit-via-http/", "to": "/git/clone-commit-via-cli/"}
- {"from": "/git/clone-commit-via-http/", "to": "/git/clone-commit-via-web/"}
Owner
Copy link

Please revert the change. The "clone via http" guide and "... ssh" guide were merged in the cli guide. The web guide only shows using the web interface, not using the CLI to clone via HTTP.

Please revert the change. The "clone via http" guide and "... ssh" guide were merged in the cli guide. The web guide only shows using the web interface, not using the CLI to clone via HTTP.
Author
Contributor
Copy link

Please revert the change. The "clone via http" guide and "... ssh" guide were merged in the cli guide. The web guide only shows using the web interface, not using the CLI to clone via HTTP.

Sorry, I undertood wrong. I'll revert it.

> Please revert the change. The "clone via http" guide and "... ssh" guide were merged in the cli guide. The web guide only shows using the web interface, not using the CLI to clone via HTTP. Sorry, I undertood wrong. I'll revert it.
fnetX marked this conversation as resolved
Author
Contributor
Copy link

Are the changes for article links from .md to / intended?

I saw that the two links to .md are now broken, changing the md extension to / fixed them, so yes, was intended.

Thanks for your review Otto 👍

> Are the changes for article links from `.md` to `/` intended? I saw that the two links to .md are now broken, changing the md extension to / fixed them, so yes, was intended. Thanks for your review Otto 👍
Owner
Copy link

OK, great. Looking forward to fixes for the two open comments. Thank you very much!

OK, great. Looking forward to fixes for the two open comments. Thank you very much!
fnetX referenced this pull request from a commit 2022年10月03日 21:35:02 +02:00
Owner
Copy link

Thank you very much!

Thank you very much!
fsologureng deleted branch fix_broken_links 2022年10月03日 22:09:45 +02:00
Author
Contributor
Copy link

Thank you very much!

You welcome :)

> Thank you very much! You welcome :)
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Codeberg Pages
Issues affecting Codeberg Pages
Documentation Usability
Issues related to using and reading docs.codeberg.org
Forgejo
Good First Issue! 👋
Kind: Bug
Kind: Documentation
Kind: Enhancement
Kind: Feature
Kind: Question
Kind: Security
Licensing
Part: Generator
This is related to the generation of the documentation, not to the content itself
Priority: High
The priority is high
Priority: Low
The priority is low
Priority: Medium
The priority is medium
Reviewed: Confirmed
Something has been confirmed
Reviewed: Duplicate
Something exists already
Reviewed: Invalid
Something was marked as invalid
Reviewed: Wontfix
Something won't be fixed
Status: Blocked
Status: Help wanted
Contributions are welcome!
Status: In progress
Work is in progress
Status: Needs feedback
Feedback is needed
Status: Ready for Review
Work is completed
Status: Review
Review is in progress / Reviewers wanted
Status: Stale
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Documentation!267
Reference in a new issue
Codeberg/Documentation
No description provided.
Delete branch "fsologureng/Documentation:fix_broken_links"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?