Codeberg/Documentation
42
199
Fork
You've already forked Documentation
161

reduce line width of content #184

Merged
fnetX merged 2 commits from lukaskluge/codeberg-documentation-lukas:main into main 2022年01月27日 14:55:58 +01:00
Contributor
Copy link

Reduces line width in main text area to increase readability

fixes #183

Reduces line width in main text area to increase readability fixes #183
Reduces line width in main text area to increase readability

Thanks for the PR.

While i agree that the current layout is not good in regards to readability, i think to max out at 80 chars is kinda too much. I'd prefer 100 chars...but thats pretty much a personal choice.

Additionally, if we limit the line width, we should increase the width of the navbar on the left. Can you add this to this PR?

Thanks for the PR. While i agree that the current layout is not good in regards to readability, i think to max out at 80 chars is kinda too much. I'd prefer 100 chars...but thats pretty much a personal choice. Additionally, if we limit the line width, we should increase the width of the navbar on the left. Can you add this to this PR?
Ghost changed title from (削除) fixes #183 (削除ここまで) to reduce line width of content 2021年12月28日 19:19:53 +01:00
Owner
Copy link

if we limit the line width, we should increase the width of the navbar on the left

The char count is a limit and will break easily on small screens. With a larger navbar, the content might become very small on small screens and become nearly unreadable. This needs to be done very carefully, and also checking if there is some Codeberg Design default we should follow.

> if we limit the line width, we should increase the width of the navbar on the left The char count is a limit and will break easily on small screens. With a larger navbar, the content might become very small on small screens and become nearly unreadable. This needs to be done very carefully, and also checking if there is some Codeberg Design default we should follow.
fnetX added the due date 2022年01月25日 2022年01月19日 20:20:23 +01:00
Owner
Copy link

image

I just checked this out, and I'm ready to merge. One weird thing I noticed: The "thank you ..." box in the footer appears to be shifted a little. Can you fix this?

![image](/attachments/7ab90940-c92c-4f7e-af78-dfc9e9025ba9) I just checked this out, and I'm ready to merge. One weird thing I noticed: The "thank you ..." box in the footer appears to be shifted a little. Can you fix this?
Owner
Copy link

by the way, since the navbar can be collapsed, I'd agree to such change if you want to, but we can also split spicing this up into a new issue.

by the way, since the navbar can be collapsed, I'd agree to such change if you want to, but we can also split spicing this up into a new issue.
Owner
Copy link

My last request was not related to this PR. Still appreciate a fix, but no need to. But I felt like this was unreasonably open for too long.

Thank you very much for this contribution.

My last request was not related to this PR. Still appreciate a fix, but no need to. But I felt like this was unreasonably open for too long. Thank you very much for this contribution.
Author
Contributor
Copy link

@fnetX Thanks, yeah sorry, I'm good at design, not so good at code, so this is the most I can do at the moment.

@fnetX Thanks, yeah sorry, I'm good at design, not so good at code, so this is the most I can do at the moment.
Owner
Copy link

I just pushed a followup, I hope nothing broke :)

I just pushed a followup, I hope nothing broke :)
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Codeberg Pages
Issues affecting Codeberg Pages
Documentation Usability
Issues related to using and reading docs.codeberg.org
Forgejo
Good First Issue! 👋
Kind: Bug
Kind: Documentation
Kind: Enhancement
Kind: Feature
Kind: Question
Kind: Security
Licensing
Part: Generator
This is related to the generation of the documentation, not to the content itself
Priority: High
The priority is high
Priority: Low
The priority is low
Priority: Medium
The priority is medium
Reviewed: Confirmed
Something has been confirmed
Reviewed: Duplicate
Something exists already
Reviewed: Invalid
Something was marked as invalid
Reviewed: Wontfix
Something won't be fixed
Status: Blocked
Status: Help wanted
Contributions are welcome!
Status: In progress
Work is in progress
Status: Needs feedback
Feedback is needed
Status: Ready for Review
Work is completed
Status: Review
Review is in progress / Reviewers wanted
Status: Stale
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2022年01月25日

Dependencies

No dependencies set.

Reference
Codeberg/Documentation!184
Reference in a new issue
Codeberg/Documentation
No description provided.
Delete branch "lukaskluge/codeberg-documentation-lukas:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?