Codeberg/Community
54
325
Fork
You've already forked Community
12

Please include a Retry-After header on 429 responses #944

Closed
opened 2023年02月20日 14:07:29 +01:00 by janderedev · 2 comments

Hello,

From what I can tell, codeberg.org uses rate limiting through a reverse proxy of some sorts. While the ratelimits are high enough for most people to never notice, migrating a particularly large repository with a lot of issues from another Gitea/Forgejo instance can trigger them.

Currently, Gitea doesn't seem to handle 429 responses at all and I've opened an issue for that, but since there's no Retry-After header present, honoring your rate limits efficiently could prove difficult.

image

Hello, From what I can tell, codeberg.org uses rate limiting through a reverse proxy of some sorts. While the ratelimits are high enough for most people to never notice, migrating a particularly large repository with a lot of issues from another Gitea/Forgejo instance can trigger them. Currently, Gitea doesn't seem to handle 429 responses at all and [I've opened an issue for that](https://github.com/go-gitea/gitea/issues/23005), but since there's no Retry-After header present, honoring your rate limits efficiently could prove difficult. ![image](/attachments/9484490b-7301-4a09-ac08-f469fbe61874)
5.3 KiB
Owner
Copy link

Relevant config lives here: https://codeberg.org/Codeberg-Infrastructure/scripted-configuration/src/branch/main/hosts/kampenwand/etc/haproxy/haproxy.cfg#L215-L218

I wonder if it can be added easily. If the calculation is not available, the retry-after would need to be a rather high value (and I don't have much knowledge of haproxy, I don't know to send two headers in case the rate limiting is triggered).

Relevant config lives here: https://codeberg.org/Codeberg-Infrastructure/scripted-configuration/src/branch/main/hosts/kampenwand/etc/haproxy/haproxy.cfg#L215-L218 I wonder if it can be added easily. If the calculation is not available, the retry-after would need to be a rather high value (and I don't have much knowledge of haproxy, I don't know to send two headers in case the rate limiting is triggered).
Owner
Copy link

I believe the switch to Caddy now sends such a header.

I believe the switch to Caddy now sends such a header.
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
accessibility

Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.
bug

Something is not working the way it should. Does not concern outages.
bug
infrastructure
Errors evidently caused by infrastructure malfunctions or outages
Codeberg

This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.
contributions welcome

Please join the discussion and consider contributing a PR!
docs

No bug, but an improvement to the docs or UI description will help
duplicate

This issue or pull request already exists
enhancement

New feature
infrastructure

Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.
legal

An issue directly involving legal compliance
licence / ToS

involving questions about the ToS, especially licencing compliance
please chill
we are volunteers
Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.
public relations

Things related to Codeberg's external communication
question

More information is needed
question
user support
This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.
s/Forgejo

Related to Forgejo. Please also check Forgejo's issue tracker.
s/Forgejo/migration

Migration related issues in Forgejo
s/Pages

Issues related to the Codeberg Pages feature
s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org
s/Woodpecker

Woodpecker CI related issue
security

involves improvements to the sites security
service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)
upstream

An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Gitea, Forgejo, etc.)
wontfix

Codeberg's current set of contributors are not planning to spend time on delegating this issue.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#944
Reference in a new issue
Codeberg/Community
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?