Codeberg/Community
54
325
Fork
You've already forked Community
12

Wrong GPG verified status or username on commits page #930

Open
opened 2023年02月09日 09:21:53 +01:00 by nkr · 0 comments
# git name git email signed by codeberg colour expected colour
1 nkr nkr@noreply.codeberg.page nkr Green Green
2 nkr nkr@noreply.codeberg.page gayathri Orange Orange
3 nkr gayathri@noreply.codeberg.page gayathri Green Orange
4 gayathri gayathri@noreply.codeberg.page nkr Orange Orange
5 gayathri nkr@noreply.codeberg.page nkr Green Orange

The commits in the table above are from this repo. The issue is that commits 3 and 5 appear in the list as made by nkr and gayathri with verified signatures, but they are not signed by those users. 3 is signed by gayathri and 5 by nkr.

Essentially, user B can set their codeberg picture to A's picture and git user.name to A's name, but user.email to B's and sign with B's keys, to get a commit that looks like from A with verified status. You have to actively click either the committer name (which will take you to B's profile) or open the commit to see that the committer is not who they pretend to be.

IMO the issue is not with the verified status. After all, the commit signature and user.email matches. The issue is that codeberg (or gitea) shows user.name from git in the commits page instead of the registered codeberg username that matches with user.email and the signature.

git's user.name should be used only if a registered user cannot be found with user.email.

| # | git name | git email | signed by | codeberg colour | expected colour | | ---------------------------------------------------------------------------------- | -------- | ------------------------------ | --------- | --------------- | --------------- | | [1](https://codeberg.org/nkr/test/commit/095ba8f589785dcc2526bac41f54e22f5229945e) | nkr | nkr@noreply.codeberg.page | nkr | Green | Green | | [2](https://codeberg.org/nkr/test/commit/c2df3ca5934afe3727f9d80fa4f5c90eb9c43b24) | nkr | nkr@noreply.codeberg.page | gayathri | Orange | Orange | | [3](https://codeberg.org/nkr/test/commit/99c8384b7835be882198205563a3a45baabac5d9) | nkr | gayathri@noreply.codeberg.page | gayathri | Green | Orange | | [4](https://codeberg.org/nkr/test/commit/9a5290607511927ad92edbcb9125c26855e38fcd) | gayathri | gayathri@noreply.codeberg.page | nkr | Orange | Orange | | [5](https://codeberg.org/nkr/test/commit/ee258d3ee9f997019d48441bd0f108d56c5a3cba) | gayathri | nkr@noreply.codeberg.page | nkr | Green | Orange | The commits in the table above are from [this repo](https://codeberg.org/nkr/test/commits/branch/main). The issue is that commits 3 and 5 appear in the list as made by `nkr` and `gayathri` with verified signatures, but they are not signed by those users. 3 is signed by `gayathri` and 5 by `nkr`. Essentially, user B can set their codeberg picture to A's picture and git user.name to A's name, but user.email to B's and sign with B's keys, to get a commit that looks like from A with verified status. You have to actively click either the committer name (which will take you to B's profile) or open the commit to see that the committer is not who they pretend to be. IMO the issue is not with the verified status. After all, the commit signature and user.email matches. The issue is that codeberg (or gitea) shows user.name from git in the commits page instead of the registered codeberg username that matches with user.email and the signature. git's user.name should be used only if a registered user cannot be found with user.email.
nkr changed title from (削除) Wrong GPG verified status (削除ここまで) to Wrong GPG verified status or user name on commits page 2023年02月09日 09:36:46 +01:00
nkr changed title from (削除) Wrong GPG verified status or user name on commits page (削除ここまで) to Wrong GPG verified status or username on commits page 2023年02月09日 09:36:55 +01:00
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
accessibility

Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.
bug

Something is not working the way it should. Does not concern outages.
bug
infrastructure

Errors evidently caused by infrastructure malfunctions or outages
Codeberg

This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.
contributions welcome

Please join the discussion and consider contributing a PR!
docs

No bug, but an improvement to the docs or UI description will help
duplicate

This issue or pull request already exists
enhancement

New feature
infrastructure

Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.
legal

An issue directly involving legal compliance
licence / ToS

involving questions about the ToS, especially licencing compliance
please chill
we are volunteers

Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.
public relations

Things related to Codeberg's external communication
question

More information is needed
question
user support

This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.
s/Forgejo

Related to Forgejo. Please also check Forgejo's issue tracker.
s/Forgejo/migration

Migration related issues in Forgejo
s/Pages

Issues related to the Codeberg Pages feature
s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org
s/Woodpecker

Woodpecker CI related issue
security

involves improvements to the sites security
service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)
upstream

An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Gitea, Forgejo, etc.)
wontfix

Codeberg's current set of contributors are not planning to spend time on delegating this issue.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#930
Reference in a new issue
Codeberg/Community
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?