Codeberg/Community
54
325
Fork
You've already forked Community
12

Hovering over referenced issue from a commit message looks worse than a similar one on the issues pages #685

Closed
opened 2022年08月10日 21:08:20 +02:00 by dminca · 6 comments

Steps to reproduce

  1. Create an 'Issue'
  2. Create a change in the repo
  3. Commit the change
    3.1. In the commit message, on line 3 write Resolves: #<issue-id> (replace with the actual Issue number created at Step 1)
  4. Push change to repo
  5. Navigate to your repo homepage
  6. Expand your commit message
  7. Hover with your mouse over the hyperlinked issue

What you see

  1. An oversized 'Issue' box (See attachment nay.png)

What you should see

  1. A symmetric box fitting all elements, especially the 'Label' (See attachment aye.png)

Other details

Reproduced on:

  • MacOS Monterey 12.5
  • Safari Version 15.6 (17613.3.9.1.5)
  • No extensions installed
<!-- NOTE: If your issue is a security concern, please send an email to contact@codeberg.org (and if related to Gitea also to security@gitea.io) instead of opening a public issue. Thank you. Welcome to the Codeberg Community Tracker. This is the right place for bug reports, feature requests and feedback. It's the central place where we track progress and discuss, so please open issues here unless you are sure it's directly related to a specific Codeberg product and only some contributors there need to join the discussion. Easy rule: If you are unsure, report it here. When reporting bugs or asking for features in the software itself, please understand that Codeberg is a fork of Gitea. Please always check upstream (→ see FAQ) if your there is already an open issue. If not, you'd really help us if you could directly get in touch with the maintainers and open an issue here if you think a wider audience should know about that (e. g. when discussing hotfixes, backports or when discussing whether some feature should become part of Gitea or a Codeberg "add-on"). If you don't have a GitHub account, please mention this and we'll gladly forward your report to the Gitea maintainers. Thank you for reporting your findings and giving feedback on Codeberg. ## Some FAQ: ### What does upstream mean? Upstream refers to Gitea, the software Codeberg is built upon. If we ask you if you can report upstream, please visit https://github.com/go-gitea/gitea/issues and check for the bug there and report elsewise. It's usually good if the person interested in a feature or bugfix opens the request to react to questions and join the discussion. We would usually just fire the report, but won't find the time to properly react to that ... **If you do not have a GitHub account**, just tell us and we'll happily forward the report for you. ### I just noticed a typo in the sign_up / sing_up route when regis... No, this is not a typo, but intentional. It was a quick fix to avoid spammers targetting our instance and it actually worked out quite well to rename the route from sign_up to sing_up (few people notice, nice to see you have sharp eyes) ... we might have to take more effective countermeasures in the future, but for now we're actually quite good with that one ... ### How can I help? If you want to help improving Codeberg as a community home for software development, we'll gladly welcome your contribution. Check out the docs about improving Codeberg https://docs.codeberg.org/improving-codeberg/ and have a look at the open issues, especially those that are looking for contribution https://codeberg.org/Codeberg/Community/issues?state=open&labels=105 - some of them don't even require much coding knowledge. We are also happy if you forward bug reports to Gitea if the original author hasn't done that yet or hasn't got a GitHub account. --> # Steps to reproduce 1. Create an 'Issue' 2. Create a change in the repo 3. Commit the change 3.1. In the commit message, on line 3 write `Resolves: #<issue-id>` (replace <issue-id> with the actual Issue number created at Step 1) 4. Push change to repo 5. Navigate to your repo homepage 6. Expand your commit message 7. Hover with your mouse over the hyperlinked issue ## What you see 8. An oversized 'Issue' box (See attachment nay.png) ## What you should see 8. A symmetric box fitting all elements, especially the 'Label' (See attachment aye.png) # Other details Reproduced on: * MacOS Monterey 12.5 * Safari Version 15.6 (17613.3.9.1.5) * No extensions installed
dminca changed title from (削除) Hovering over a referenced issue from a commit message reveals an oversized "Issue" box (削除ここまで) to Hovering over a referenced issue from a commit message on Safari reveals an oversized "Issue" box 2022年08月10日 22:02:42 +02:00

The 'correct' image seems to be github, but a bit of asking on matrix gave us a good comparison of a 'good' page and you can see this by hovering over the issue references in the issue page as opposed to the commit page.

See, for an example of a better looking popup this page: #682

The 'correct' image seems to be github, but a bit of asking on matrix gave us a good comparison of a 'good' page and you can see this by hovering over the issue references in the issue page as opposed to the commit page. See, for an example of a better looking popup this page: https://codeberg.org/Codeberg/Community/issues/682
Author
Copy link

It was the only one I knew about at the moment of writing this issue.

It was the only one I knew about at the moment of writing this issue.

My suggestion for title;

"Hovering over referenced issue from a commit message looks worse than a similar one on the issues pages".

My suggestion for title; "Hovering over referenced issue from a commit message looks worse than a similar one on the issues pages".
Author
Copy link

Caching and naming things are still the most popular problems in Engineering.

Yup, your suggestion makes more sense :) -- changed!

Caching and naming things are still the most popular problems in Engineering. Yup, your suggestion makes more sense :) -- changed!
dminca changed title from (削除) Hovering over a referenced issue from a commit message on Safari reveals an oversized "Issue" box (削除ここまで) to Hovering over referenced issue from a commit message looks worse than a similar one on the issues pages 2022年08月11日 13:32:12 +02:00

This bug will be fixed in Gitea 1.18 with https://github.com/go-gitea/gitea/pull/20428/.

This bug will be fixed in Gitea 1.18 with https://github.com/go-gitea/gitea/pull/20428/.

v1.18 has been deployed. Feel free to re-open if this issue persists.

v1.18 has been deployed. Feel free to re-open if this issue persists.
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
accessibility

Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.
bug

Something is not working the way it should. Does not concern outages.
bug
infrastructure

Errors evidently caused by infrastructure malfunctions or outages
Codeberg

This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.
contributions welcome

Please join the discussion and consider contributing a PR!
docs

No bug, but an improvement to the docs or UI description will help
duplicate

This issue or pull request already exists
enhancement

New feature
infrastructure

Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.
legal

An issue directly involving legal compliance
licence / ToS

involving questions about the ToS, especially licencing compliance
please chill
we are volunteers

Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.
public relations

Things related to Codeberg's external communication
question

More information is needed
question
user support

This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.
s/Forgejo

Related to Forgejo. Please also check Forgejo's issue tracker.
s/Forgejo/migration

Migration related issues in Forgejo
s/Pages

Issues related to the Codeberg Pages feature
s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org
s/Woodpecker

Woodpecker CI related issue
security

involves improvements to the sites security
service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)
upstream

An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Gitea, Forgejo, etc.)
wontfix

Codeberg's current set of contributors are not planning to spend time on delegating this issue.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#685
Reference in a new issue
Codeberg/Community
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?