Issue tab shows other people's repos #663

fnetX commented 2022年07月20日 13:44:55 +02:00

I recall vaguely that we had this issue in the past, and fixed it, also with an early Codeberg patch (cc @ashimokawa).

If I open my personal Issue view at https://codeberg.org/issues, I see some repos I can't understand my relation with, e.g.

• Freeyourgadget/Gadgetbridge
• Fundevogel/kirby3-charts
• shadow/SpyWareWatchdog

e.g. for Gadgetbridge: I'm not a member, nor watching it and I don't understand why I see a display of all the issues there. It's very confusing and looks broken IMHO.

I recall vaguely that we had this issue in the past, and fixed it, also with an early Codeberg patch (cc @ashimokawa). If I open my personal Issue view at https://codeberg.org/issues, I see some repos I can't understand my relation with, e.g. - Freeyourgadget/Gadgetbridge - Fundevogel/kirby3-charts - shadow/SpyWareWatchdog e.g. for Gadgetbridge: I'm not a member, nor watching it and I don't understand why I see a display of all the issues there. It's very confusing and looks broken IMHO.

fnetX commented 2022年07月20日 13:59:14 +02:00

Okay, another relation found: Fundevogel/kirby3-charts#2 (comment)

still very confusing IMHO, this should be changed.

Okay, another relation found: https://codeberg.org/Fundevogel/kirby3-charts/issues/2#issuecomment-465228 still very confusing IMHO, this should be changed.

fnetX commented 2022年07月20日 13:59:40 +02:00

(= only show issues I'm related to, not automatically show all issues of the repos where I'm related to one issue only)

(= only show issues I'm related to, not automatically show all issues of the repos where I'm related to one issue only)

algernon commented 2023年12月17日 12:01:41 +01:00

All of the dashboard pages (pull requests, issues, milestones) build a list of repositories the user has access to, and display all PRs, issues, milestones within them, and allow filtering those (the code that collects these is in routers/web/user/home.go). It has no relation whatsoever to what one would expect: things the user has a relation to (other than access). If I open a PR against a repo I don't own, or have collaborator access to, it will not show up on the dashboard. This, I feel, renders these dashboards pretty much useless.

Rather than searching for repositories the user owns or has collaborator permissions for, these pages should list issues the user subscribed or contributed to. Though, if someone has posted a comment, but did not subscribe to the issue, I believe that should not be listed.

To put it more bluntly, this is how the list of things should be generated:

• Any PR, issue, or milestone created by the user/org/team should be included.
• Any PR, issue, or milestone assigned to the user/org/team should be included.
• Any PR, issue, or milestone mentioning the user/org/team should be included.
• Any PR, issue, or milestone the user/org/team is subscribed to should be included.

And that's it. This is pretty much how GitHub does it, as far as I can tell. GitLab is more limited: by default, /dashboard/issues will show issues assigned to the user only. Both GitHub and GitLab allow issue and PR searching, though, which lets one relax the conditions.

I think that as a first step, we should redo the list without a custom searchability option that GitHub and GitLab provide - that can be implemented separately, later.

I feel that a lot of the code from the user activity page could be reused for this purpose - I'll have a look.

All of the dashboard pages (pull requests, issues, milestones) build a list of repositories the user has access to, and display *all* PRs, issues, milestones within them, and allow filtering those (the code that collects these is in [`routers/web/user/home.go`](https://codeberg.org/forgejo/forgejo/src/commit/a94488cc989f48a5bc4418c1136e760a4871f9d1/routers/web/user/home.go)). It has no relation whatsoever to what one would expect: things the user has a relation to (other than access). If I open a PR against a repo I don't own, or have collaborator access to, it will not show up on the dashboard. This, I feel, renders these dashboards pretty much useless. Rather than searching for repositories the user owns or has collaborator permissions for, these pages should list issues the user subscribed or contributed to. Though, if someone has posted a comment, but did *not* subscribe to the issue, I believe that should not be listed. To put it more bluntly, this is how the list of things should be generated: - Any PR, issue, or milestone created by the user/org/team should be included. - Any PR, issue, or milestone assigned to the user/org/team should be included. - Any PR, issue, or milestone mentioning the user/org/team should be included. - Any PR, issue, or milestone the user/org/team is subscribed to should be included. And that's it. This is pretty much how GitHub does it, as far as I can tell. GitLab is more limited: by default, `/dashboard/issues` will show issues assigned to the user only. Both GitHub and GitLab allow issue and PR searching, though, which lets one relax the conditions. I think that as a first step, we should redo the list without a custom searchability option that GitHub and GitLab provide - that can be implemented separately, later. I *feel* that a lot of the code from the user activity page could be reused for this purpose - I'll have a look.

fnetX commented 2023年12月17日 14:05:37 +01:00

Oh, I think that the code must have changed between 1.20 and 1.21. Some repos that annoyed me a lot are now gone. (In the past, I always wondered what brought them up, since I had no access to them or something).

I suggest that we put this on hold and try to arrange a brainstorming about how we put these special pages to good use.

Oh, I think that the code must have changed between 1.20 and 1.21. Some repos that annoyed me a lot are now gone. (In the past, I always wondered what brought them up, since I had no access to them or something). I suggest that we put this on hold and try to arrange a brainstorming about how we put these special pages to good use.

Ganblejs commented 2024年03月06日 23:33:35 +01:00

To put it more bluntly, this is how the list of things should be generated:

I think I agree with @algernon's list.

I might have also liked the option to include everything from repositories that I 'Watch' - not only the PR/Issues/Milestones on them that I have interacted with or otherwise been associated with. But I'm not certain on this one.

> To put it more bluntly, this is how the list of things should be generated: I think I agree with @algernon's list. I might have also liked the option to include everything from repositories that I 'Watch' - not only the PR/Issues/Milestones on them that I have interacted with or otherwise been associated with. But I'm not certain on this one.