Broken links referring from pkg.go.dev to codeberg.org #413

ac commented 2021年03月08日 17:52:25 +01:00

It looks like the links used on pkg.go.dev (Golang package documentation companion) that refer to packages on codeberg.org are broken.

They use links with abbreviated git commit hashes and gitea seems to 404 those instead of redirecting them to the long notation.

Example: https://pkg.go.dev/codeberg.org/ac/ecdh25519

If you click on any link on this page that refers to a specific file on codeberg.org, then the links resolves to a 404.

Let's go into detail:

Go to https://pkg.go.dev/codeberg.org/ac/ecdh25519#section-sourcefiles and take a look at the link for the file ecdh25519.go.

It refers to ac/ecdh25519@8a2cf2a5c9/ecdh25519.go

If you call that link, you'll receive a 404:

$ curl -I https://codeberg.org/ac/ecdh25519/src/commit/8a2cf2a5c93c/ecdh25519.go
HTTP/2 404
...

The correct permalink is however:

ac/ecdh25519@8a2cf2a5c9/ecdh25519.go

Workaround:

Either redirect the short form to the long form or provide an alternative src/commit/{short}/sourcefile as an alternative path.

I also opened an issue at the go community. https://github.com/golang/go/issues/44865

It looks like the links used on pkg.go.dev (Golang package documentation companion) that refer to packages on codeberg.org are broken. They use links with abbreviated git commit hashes and gitea seems to 404 those instead of redirecting them to the long notation. Example: https://pkg.go.dev/codeberg.org/ac/ecdh25519 If you click on any link on this page that refers to a specific file on codeberg.org, then the links resolves to a 404. Let's go into detail: Go to https://pkg.go.dev/codeberg.org/ac/ecdh25519#section-sourcefiles and take a look at the link for the file ecdh25519.go. It refers to https://codeberg.org/ac/ecdh25519/src/commit/8a2cf2a5c93c/ecdh25519.go If you call that link, you'll receive a 404: ``` $ curl -I https://codeberg.org/ac/ecdh25519/src/commit/8a2cf2a5c93c/ecdh25519.go HTTP/2 404 ... ``` The correct permalink is however: > https://codeberg.org/ac/ecdh25519/src/commit/8a2cf2a5c93c3fb69f0e6161f4bb82dcc3584b0/ecdh25519.go Workaround: Either redirect the short form to the long form or provide an alternative src/commit/{short}/sourcefile as an alternative path. I also opened an issue at the go community. https://github.com/golang/go/issues/44865

6543 commented 2021年03月08日 18:04:28 +01:00

@ac this is a gitea bug witch is fixed on master. witch mean gitea <= 1.13.4 only is afected :/

test for upcomming release:

• https://try.gitea.io/abcKing/ecdh25519/src/commit/8a2cf2a5c93c/ecdh25519.go
• https://try.gitea.io/abcKing/ecdh25519/src/commit/8a2cf2a5c93c3fb69f0e6161f4bb82dccc3584b0/ecdh25519.go

@ac this is a gitea bug witch is fixed on master. witch mean gitea <= 1.13.4 only is afected :/ test for upcomming release: * `https://try.gitea.io/abcKing/ecdh25519/src/commit/8a2cf2a5c93c/ecdh25519.go` * `https://try.gitea.io/abcKing/ecdh25519/src/commit/8a2cf2a5c93c3fb69f0e6161f4bb82dccc3584b0/ecdh25519.go`

fnetX commented 2021年03月08日 18:38:45 +01:00

Does it make sense to backport this for Codeberg?

Does it make sense to backport this for Codeberg?

6543 commented 2021年03月08日 18:48:55 +01:00

@fnetX it would be a custom bugfix (no backport) ... I can have a look at it, but not right now.

@fnetX it would be a custom bugfix (no backport) ... I can have a look at it, but not right now.

fnetX commented 2021年03月08日 18:57:45 +01:00

@ac how much of a breaker is it to you (and supposedly others) at the moment? I mean, clicking on the link still finds the correct repo, but not at the correct timestamp.

@6543 Gitea 1.14 is to be expected rather soon, right?

@ac how much of a breaker is it to you (and supposedly others) at the moment? I mean, clicking on the link still finds the correct repo, but not at the correct timestamp. @6543 Gitea 1.14 is to be expected rather soon, right?

ac commented 2021年03月08日 19:43:02 +01:00

@fnetX Codeberg/Go users may be irritated by it. But since the issue is known and it is just a matter of time for a fixed release, I don't think that there is any hurry for backports or alike.

Just a minor malfunction, as annoying as it is, just like all the bugs in the world. I only wanted it to be taken on and be solved sooner rather than later.

Thank you!

@fnetX Codeberg/Go users may be irritated by it. But since the issue is known and it is just a matter of time for a fixed release, I don't think that there is any hurry for backports or alike. Just a minor malfunction, as annoying as it is, just like all the bugs in the world. I only wanted it to be taken on and be solved sooner rather than later. Thank you!