Codeberg/Community
54
325
Fork
You've already forked Community
12

Thumbnail on Firefox looks squished #318

Closed
opened 2020年10月25日 05:46:47 +01:00 by Yeldham · 13 comments

The thumbnail that appears in the "New tab" page on Firefox looks horizontally squished.

This may be on Firefox's end, but I didn't notice this happen on other web pages.

The thumbnail that appears in the "New tab" page on Firefox looks horizontally squished. This may be on Firefox's end, but I didn't notice this happen on other web pages.

Looks like ditching the text and keeping the logo itself should do the trick to get it unsquished?!

Looks like ditching the text and keeping the logo itself should do the trick to get it unsquished?!
Author
Copy link

@ojn Most sites just go with the logo alone for those as well, so it would also be consistent.

@ojn Most sites just go with the logo alone for those as well, so it would also be consistent.
Member
Copy link

Can you see in the console what file is used to render this?

Can you see in the console what file is used to render this?
Author
Copy link

@hw I know nothing of web development, so you will need to guide me here.

@hw I know nothing of web development, so you will need to guide me here.
Owner
Copy link

I think it might be this "fluid" icon:

	<link rel="fluid-icon" href="/img/gitea-lg.png" title="Codeberg.org">

https://codeberg.org/img/gitea-lg.png

I think it might be this "fluid" icon: ``` <link rel="fluid-icon" href="/img/gitea-lg.png" title="Codeberg.org"> ``` https://codeberg.org/img/gitea-lg.png
Author
Copy link

Forgot about this report, but currently the preview shows the favicon, and now it looks correct.

So I will be closing this.

Forgot about this report, but currently the preview shows the favicon, and now it looks correct. So I will be closing this.
Owner
Copy link

... still wonder why this exists in the code, I can't imagine a reason for such a wide icon. Seems to be different on latest Gitea, will this be different in a newer version or is it an issue with our deployment?

cc @6543

... still wonder why this exists in the code, I can't imagine a reason for such a wide icon. Seems to be different on latest Gitea, will this be different in a newer version or is it an issue with our deployment? cc @6543

I think this is some codeberg specific thing ...

PS: on migration to v1.14.0 logo will have new name: logo not gitea as it was in the past ...

will write it down in #348

I think this is some codeberg specific thing ... PS: on migration to v1.14.0 logo will have new name: `logo` not `gitea` as it was in the past ... will write it down in #348
Owner
Copy link

still valid and reproducible, bookmark (in toolbar) appears to be using that squished version ...

still valid and reproducible, bookmark (in toolbar) appears to be using that squished version ...
Owner
Copy link

I tested fnetX/build-deploy-gitea@f3c390159d quite intensively and I assume it will fix the issue.
Weird thing that I didn't manage to understand is that the logo display was fine on codeberg-test.org without this change and with the before-1.14 code, although it served the very same weird gitea-lg image.

@6543 you said that Gitea 1.14 will change logo paths etc? I assume it's better to correct this in one rush? Is the deployment scripts in build-deploy-gitea already updated? Doesn't look like there was such a change recently.

I tested https://codeberg.org/fnetX/build-deploy-gitea/commit/f3c390159d6f43849a2852b2f1dd9b57e48cf7b6 quite intensively and I assume it will fix the issue. Weird thing that I didn't manage to understand is that the logo display was fine on codeberg-test.org without this change and with the before-1.14 code, although it served the very same weird gitea-lg image. @6543 you said that Gitea 1.14 will change logo paths etc? I assume it's better to correct this in one rush? Is the deployment scripts in build-deploy-gitea already updated? Doesn't look like there was such a change recently.

It's not completly updated as far as i can tell

It's not completly updated as far as i can tell

For me this seems to be fixed, logo displays fine in "New Tab" view, tab bar and bookmarks.

Can someone please confirm.

For me this seems to be fixed, logo displays fine in "New Tab" view, tab bar and bookmarks. Can someone please confirm.
Owner
Copy link

It looks like the initial report in Codeberg/build-deploy-gitea#62 for me (rest got offtopic). Same for you?

It looks like the initial report in Codeberg/build-deploy-gitea#62 for me (rest got offtopic). Same for you?
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
accessibility

Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.
bug

Something is not working the way it should. Does not concern outages.
bug
infrastructure
Errors evidently caused by infrastructure malfunctions or outages
Codeberg

This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.
contributions welcome

Please join the discussion and consider contributing a PR!
docs

No bug, but an improvement to the docs or UI description will help
duplicate

This issue or pull request already exists
enhancement

New feature
infrastructure

Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.
legal

An issue directly involving legal compliance
licence / ToS

involving questions about the ToS, especially licencing compliance
please chill
we are volunteers
Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.
public relations

Things related to Codeberg's external communication
question

More information is needed
question
user support
This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.
s/Forgejo

Related to Forgejo. Please also check Forgejo's issue tracker.
s/Forgejo/migration

Migration related issues in Forgejo
s/Pages

Issues related to the Codeberg Pages feature
s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org
s/Woodpecker

Woodpecker CI related issue
security

involves improvements to the sites security
service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)
upstream

An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Gitea, Forgejo, etc.)
wontfix

Codeberg's current set of contributors are not planning to spend time on delegating this issue.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#318
Reference in a new issue
Codeberg/Community
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?