Codeberg/Community
54
325
Fork
You've already forked Community
12

Wildcard Serving #259

Closed
opened 2020年09月14日 14:11:21 +02:00 by n · 11 comments

As discussed in #227, wildcard serving is hurting search results for Codeberg.
I propose returning a 404 error or redirecting to codeberg.org/*.

As discussed in #227, wildcard serving is hurting search results for Codeberg. I propose returning a 404 error or redirecting to `codeberg.org/*`.
Member
Copy link

We need a proper technical solution here: redirects do not work as browsers reject them with certificate error. Any idea?

We need a proper technical solution here: redirects do not work as browsers reject them with certificate error. Any idea?

@hw - While a redirect wouldn't work for browsers, it would work for crawlers, preventing duplicate search results. But in general, returning 404 Not Found would be the cleaner solution, as redirecting suggests the URL is valid.

@hw - While a redirect wouldn't work for browsers, it would work for crawlers, preventing duplicate search results. But in general, returning `404 Not Found` would be the cleaner solution, as redirecting suggests the URL is valid.
Member
Copy link

crawlers are redirected to TLS too, and then fail the cert check just like a browser?

crawlers are redirected to TLS too, and then fail the cert check just like a browser?

The search results from the other issue suggested differently, if I remember correctly. But either way, I think a 404 would be the better option 😉

The search results from the other issue suggested differently, if I remember correctly. But either way, I think a 404 would be the better option :wink:
Author
Copy link

Any updates on this @hw?

Any updates on this @hw?
Member
Copy link

Not really

Not really
Owner
Copy link

I don't understand the issue tbh. We only redirect to the main domain for a while now. Do I miss something or is this outdated?

I don't understand the issue tbh. We only redirect to the main domain for a while now. Do I miss something or is this outdated?
Author
Copy link

Subdomains like mail.codeberg.org and smtp.codeberg.org still serve the Codeberg website rather than redirecting or returning an error. Although it doesn't appear to be a problem for search results anymore.

Subdomains like [mail.codeberg.org](https://mail.codeberg.org/) and [smtp.codeberg.org](https://smtp.codeberg.org) still serve the Codeberg website rather than redirecting or returning an error. Although it doesn't appear to be a problem for search results anymore.
Owner
Copy link

Huh? Wow.

Huh? Wow.

mail.codeberg.org and smtp.codeberg.org are now answered by the pages server it seems.

Should pages react to *.codeberg.org in the first place?

mail.codeberg.org and smtp.codeberg.org are now answered by the pages server it seems. Should pages react to *.codeberg.org in the first place?
Owner
Copy link

Well, the setup is that everything haproxy does not know is forwarded to the Pages Server, because it might be a custom domain.

It's same like opening https://thispagedoesnotexist123456.codeberg.page. I also think it resolves the initial problem discussed here, because the Pages Server explicitly responds with 404 already.

If we want to fancy this up, we could add targets for known *.codeberg.org names that we want to get rid of and close the connection, or serve another 404 Page.

Oh, and I plan to get rid of the DNS wildcard for codeberg.org, too. This would also make this fancier in the future.

Well, the setup is that everything haproxy does not know is forwarded to the Pages Server, because it *might* be a custom domain. It's same like opening https://thispagedoesnotexist123456.codeberg.page. I also think it resolves the initial problem discussed here, because the Pages Server explicitly responds with 404 already. If we want to fancy this up, we could add targets for known *.codeberg.org names that we want to get rid of and close the connection, or serve another 404 Page. Oh, and I plan to get rid of the DNS wildcard for codeberg.org, too. This would also make this fancier in the future.
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
accessibility

Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.
bug

Something is not working the way it should. Does not concern outages.
bug
infrastructure

Errors evidently caused by infrastructure malfunctions or outages
Codeberg

This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.
contributions welcome

Please join the discussion and consider contributing a PR!
docs

No bug, but an improvement to the docs or UI description will help
duplicate

This issue or pull request already exists
enhancement

New feature
infrastructure

Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.
legal

An issue directly involving legal compliance
licence / ToS

involving questions about the ToS, especially licencing compliance
please chill
we are volunteers

Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.
public relations

Things related to Codeberg's external communication
question

More information is needed
question
user support

This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.
s/Forgejo

Related to Forgejo. Please also check Forgejo's issue tracker.
s/Forgejo/migration

Migration related issues in Forgejo
s/Pages

Issues related to the Codeberg Pages feature
s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org
s/Woodpecker

Woodpecker CI related issue
security

involves improvements to the sites security
service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)
upstream

An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Gitea, Forgejo, etc.)
wontfix

Codeberg's current set of contributors are not planning to spend time on delegating this issue.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#259
Reference in a new issue
Codeberg/Community
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?