Unable to open a pull request #2524

Cloudef commented 2026年04月17日 10:48:41 +02:00

Comment

For some reason I'm unable to open pull requests for any branch from my zig fork. Everytime I try it leads to Internal Server Error 500.

For example try this link https://codeberg.org/ziglang/zig/compare/master...Cloudef/zig:std.os.linux-constCast

### Comment For some reason I'm unable to open pull requests for any branch from my zig fork. Everytime I try it leads to Internal Server Error 500. For example try this link <https://codeberg.org/ziglang/zig/compare/master...Cloudef/zig:std.os.linux-constCast>

mahlzahn commented 2026年04月17日 11:24:20 +02:00

That is weird. I confirm that all comparisons from your fork to ziglang fail with 500 Error.

I tried with a fork of your fork at /mahlzahn-codeberg/zig-test-from-Cloudef and it is not failing neither comparing to your fork nor to the original ziglang:
https://codeberg.org/Cloudef/zig/compare/master...mahlzahn-codeberg/zig-test-from-Cloudef:std.os.linux-constCast
https://codeberg.org/ziglang/zig/compare/master...mahlzahn-codeberg/zig-test-from-Cloudef:std.os.linux-constCast

@Gusted Do you want to have look at this?

That is weird. I confirm that all comparisons from your fork to ziglang fail with 500 Error. I tried with a fork of your fork at [[/mahlzahn-codeberg/zig-test-from-Cloudef]] and it is not failing neither comparing to your fork nor to the original ziglang: https://codeberg.org/Cloudef/zig/compare/master...mahlzahn-codeberg/zig-test-from-Cloudef:std.os.linux-constCast https://codeberg.org/ziglang/zig/compare/master...mahlzahn-codeberg/zig-test-from-Cloudef:std.os.linux-constCast @Gusted Do you want to have look at this?

Gusted commented 2026年04月17日 19:02:59 +02:00

Ah, left over lock file. Haven't seen that for a while. Fixed!

Ah, left over lock file. Haven't seen that for a while. Fixed!

Cloudef commented 2026年04月18日 01:36:12 +02:00

Is it normal that https://codeberg.org/ziglang/zig/compare/master...Cloudef/zig:std.os.linux-constCast shows this many commits, should only have 1

commit 05cfa5c608ddb8080722a2b46e84ee05b645d839 (HEAD -> std.os.linux-constCast, origin/std.os.linux-constCast)
Author: Jari Vetoniemi <jari.vetoniemi@cloudef.pw>
Date: Fri Mar 20 04:53:35 2026 +0900
 std.os.linux: const timespec for ppoll
 removes the need of `@constCast` in poll
commit ff612334fa8af05c42b71f784dff521899026f97 (upstream/master, upstream/HEAD, master)
Author: Josh Megnauth <jo.sh@tutanota.com>
Date: Thu Apr 9 14:53:40 2026 -0400
 libzigc: dup2 and dup3
 This commit adds `dup2` and `dup3` based on musl. Zig already has
 wrappers for the syscalls, but musl's implementation checks for a rare,
 temporary race condition with dup2/3 and `open`. Like musl, this
 implementation adds a fallback for dup3 if the syscall isn't available.
 Contributes to: #30978

~/d/p/zig std.os.linux-constCast ❱ git diff upstream/master
diff --git a/lib/std/os/linux.zig b/lib/std/os/linux.zig
index ffe9ef15f3..09bb8d3681 100644
--- a/lib/std/os/linux.zig
+++ b/lib/std/os/linux.zig
@@ -1263,17 +1263,17 @@ pub fn poll(fds: [*]pollfd, n: nfds_t, timeout: i32) usize {
 fds,
 n,
 if (timeout >= 0)
- @constCast(&timespec{
+ &.{
 .sec = @divTrunc(timeout, 1000),
 .nsec = @rem(timeout, 1000) * 1000000,
- })
+ }
 else
 null,
 null,
 );
 }
-pub fn ppoll(fds: [*]pollfd, n: nfds_t, timeout: ?*timespec, sigmask: ?*const sigset_t) usize {
+pub fn ppoll(fds: [*]pollfd, n: nfds_t, timeout: ?*const timespec, sigmask: ?*const sigset_t) usize {
 return syscall5(
 if (@hasField(SYS, "ppoll") and native_arch != .hexagon) .ppoll else .ppoll_time64,
 @intFromPtr(fds),

Is it normal that <https://codeberg.org/ziglang/zig/compare/master...Cloudef/zig:std.os.linux-constCast> shows this many commits, should only have 1 ``` commit 05cfa5c608ddb8080722a2b46e84ee05b645d839 (HEAD -> std.os.linux-constCast, origin/std.os.linux-constCast) Author: Jari Vetoniemi <jari.vetoniemi@cloudef.pw> Date: Fri Mar 20 04:53:35 2026 +0900 std.os.linux: const timespec for ppoll removes the need of `@constCast` in poll commit ff612334fa8af05c42b71f784dff521899026f97 (upstream/master, upstream/HEAD, master) Author: Josh Megnauth <jo.sh@tutanota.com> Date: Thu Apr 9 14:53:40 2026 -0400 libzigc: dup2 and dup3 This commit adds `dup2` and `dup3` based on musl. Zig already has wrappers for the syscalls, but musl's implementation checks for a rare, temporary race condition with dup2/3 and `open`. Like musl, this implementation adds a fallback for dup3 if the syscall isn't available. Contributes to: #30978 ``` ```diff ~/d/p/zig std.os.linux-constCast ❱ git diff upstream/master diff --git a/lib/std/os/linux.zig b/lib/std/os/linux.zig index ffe9ef15f3..09bb8d3681 100644 --- a/lib/std/os/linux.zig +++ b/lib/std/os/linux.zig @@ -1263,17 +1263,17 @@ pub fn poll(fds: [*]pollfd, n: nfds_t, timeout: i32) usize { fds, n, if (timeout >= 0) - @constCast(&timespec{ + &.{ .sec = @divTrunc(timeout, 1000), .nsec = @rem(timeout, 1000) * 1000000, - }) + } else null, null, ); } -pub fn ppoll(fds: [*]pollfd, n: nfds_t, timeout: ?*timespec, sigmask: ?*const sigset_t) usize { +pub fn ppoll(fds: [*]pollfd, n: nfds_t, timeout: ?*const timespec, sigmask: ?*const sigset_t) usize { return syscall5( if (@hasField(SYS, "ppoll") and native_arch != .hexagon) .ppoll else .ppoll_time64, @intFromPtr(fds), ```

Cloudef commented 2026年04月22日 18:24:52 +02:00

@Gusted sorry for ping ^

@Gusted sorry for ping ^

Cloudef commented 2026年04月27日 12:33:36 +02:00

Seems to be fixed now. Thank you!

Seems to be fixed now. Thank you!

iago-lito commented 2026年05月06日 09:22:46 +02:00

I've got the same problem on private repos here. Creating MRs results in a 500 :( Should we reopen?

I've got the same problem on private repos here. Creating MRs results in a 500 :( Should we reopen?

Gusted commented 2026年05月06日 11:50:08 +02:00

@iago-lito Have a look at #2592 (resolved now)

@iago-lito Have a look at https://codeberg.org/Codeberg/Community/issues/2592 (resolved now)