Codeberg/Community
60
387
Fork
You've already forked Community
12

file-in-commit link rendered wrong in issue comment #2477

Open
opened 2026年03月28日 00:34:56 +01:00 by nektro · 4 comments

Comment

example: ziglang/zig#31421 (comment)

source:

above fix included in https://codeberg.org/ziglang/zig/commit/9ac1386c10736bc249f3891f34f23424531917a5?files=lib/std/Thread.zig

output:

<div id="issuecomment-12256734-content" class="render-content markup" data-can-edit="true">
 <p dir="auto">above fix included in <a href="https://codeberg.org/ziglang/zig/commit/9ac1386c10736bc249f3891f34f23424531917a5?files=lib" rel="nofollow"><code>9ac1386c10</code></a>/std/Thread.zig</p>
</div>
### Comment example: https://codeberg.org/ziglang/zig/issues/31421#issuecomment-12256734 source: ```md above fix included in https://codeberg.org/ziglang/zig/commit/9ac1386c10736bc249f3891f34f23424531917a5?files=lib/std/Thread.zig ``` output: ```html <div id="issuecomment-12256734-content" class="render-content markup" data-can-edit="true"> <p dir="auto">above fix included in <a href="https://codeberg.org/ziglang/zig/commit/9ac1386c10736bc249f3891f34f23424531917a5?files=lib" rel="nofollow"><code>9ac1386c10</code></a>/std/Thread.zig</p> </div> ```
nektro changed title from (削除) file-in-commit rendered wrong in issue comment (削除ここまで) to file-in-commit link rendered wrong in issue comment 2026年03月28日 00:35:21 +01:00
Author
Copy link

the link should not be broken

image

the link should not be broken ![image](/attachments/37039242-ba11-4b61-939a-988218e2491e)

To link to a certain diff you may use ziglang/zig@9ac1386c10 (diff-9f425a21d).

Where did the link with files=... parameter come from?

To link to a certain diff you may use https://codeberg.org/ziglang/zig/commit/9ac1386c10736bc249f3891f34f23424531917a5#diff-9f425a21d2ab692560a604206c5d7faf0b9db60a. Where did the link with `files=...` parameter come from?

A fix should be simple by adding / to the concerning regular expression in

anyHashPattern=regexp.MustCompile(`https?://[^\s/]+/(\S+/(?:commit|tree|blob))/([0-9a-f]{7,64})(/[-+~_%.a-zA-Z0-9/]+)?(\?[-+~_%\.a-zA-Z0-9=&]+)?(#[-+~_%.a-zA-Z0-9]+)?`)

just like in

comparePattern=regexp.MustCompile(`https?://[^\s/]+/(?:\S+/)?([^\s/]+/[^\s/]+)/compare/([0-9a-f]{7,64})(\.\.\.?)([0-9a-f]{7,64})?(\?[-+~_%\.a-zA-Z0-9=&/]+)?(#[-+~_%.a-zA-Z0-9]+)?`)
-(\?[-+~_%\.a-zA-Z0-9=&]+)?
+(\?[-+~_%\.a-zA-Z0-9=&/]+)?
A fix should be simple by adding `/` to the concerning regular expression in https://codeberg.org/forgejo/forgejo/src/commit/b68caa311fe5e3b7118130c2894c5b396b319681/modules/markup/html.go#L61 just like in https://codeberg.org/forgejo/forgejo/src/commit/b68caa311fe5e3b7118130c2894c5b396b319681/modules/markup/html.go#L64 ```diff -(\?[-+~_%\.a-zA-Z0-9=&]+)? +(\?[-+~_%\.a-zA-Z0-9=&/]+)? ```
Author
Copy link

Where did the link with files=... parameter come from?

history https://codeberg.org/ziglang/zig/commits/branch/master/lib/std/Thread.zig, link in 2nd to last column

> Where did the link with `files=...` parameter come from? history https://codeberg.org/ziglang/zig/commits/branch/master/lib/std/Thread.zig, link in 2nd to last column
Sign in to join this conversation.
No Branch/Tag specified
main
No results found.
Labels
Clear labels
accessibility
Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.
bug
Something is not working the way it should. Does not concern outages.
bug
infrastructure
 Errors evidently caused by infrastructure malfunctions or outages
Codeberg
This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.
contributions welcome
Please join the discussion and consider contributing a PR!
docs
No bug, but an improvement to the docs or UI description will help
duplicate
This issue or pull request already exists
enhancement
New feature
infrastructure
Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.
legal
An issue directly involving legal compliance
licence / ToS
involving questions about the ToS, especially licencing compliance
please chill
we are volunteers
 Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.
public relations
Things related to Codeberg's external communication
question
More information is needed
question
user support
 This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.
s/Forgejo
Related to Forgejo. Please also check Forgejo's issue tracker.
s/Forgejo/migration
Migration related issues in Forgejo
s/Pages
Issues related to the Codeberg Pages feature
s/Weblate
Issue is related to the Weblate instance at https://translate.codeberg.org
s/Woodpecker
Woodpecker CI related issue
security
involves improvements to the sites security
service
Add a new service to the Codeberg ecosystem (instead of implementing into Forgejo)
upstream
An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Forgejo, Weblate, etc.)
wontfix
Codeberg's current set of contributors are not planning to spend time on delegating this issue.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#2477
Reference in a new issue
Codeberg/Community
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?