Changes to the concurrency.group expression do not seem to be picked up #2318

alexrp commented 2026年01月16日 14:51:32 +01:00

Comment

I changed Zig's concurrency.group value in: ziglang/zig@65a4dbc503

The previous value was problematic because it meant that if the same user pushed to a ref more than once in a row, all of those workflows would run serially. IIRC, it didn't work like that on GitHub, but I also don't really care that much about 1:1 GitHub compatibility, and I think Forgejo's implementation is more consistent with the documented semantics anyway.

Unfortunately, though, it seems like the new value didn't take. I scheduled two runs manually:

• https://codeberg.org/ziglang/zig/actions/runs/975
• https://codeberg.org/ziglang/zig/actions/runs/976

As you can see, they both seem to be blocked by the concurrency group still, with presumably this run taking up the spot: https://codeberg.org/ziglang/zig/actions/runs/973

My vague suspicion here is that Forgejo is still using the old concurrency.group expression, but I'm not sure how to even verify that.

cc @Gusted @mfenniak

### Comment I changed Zig's `concurrency.group` value in: https://codeberg.org/ziglang/zig/commit/65a4dbc5034cff2cd9f258f764a0e684cb22ac97 The previous value was problematic because it meant that if the same user pushed to a ref more than once in a row, all of those workflows would run serially. IIRC, it didn't work like that on GitHub, but I also don't really care that much about 1:1 GitHub compatibility, and I think Forgejo's implementation is more consistent with the documented semantics anyway. Unfortunately, though, it seems like the new value didn't take. I scheduled two runs manually: * https://codeberg.org/ziglang/zig/actions/runs/975 * https://codeberg.org/ziglang/zig/actions/runs/976 As you can see, they both seem to be blocked by the concurrency group still, with presumably this run taking up the spot: https://codeberg.org/ziglang/zig/actions/runs/973 My vague suspicion here is that Forgejo is still using the old `concurrency.group` expression, but I'm not sure how to even verify that. cc @Gusted @mfenniak

alexrp commented 2026年01月16日 14:56:49 +01:00

Actually, it seems like I might've confused head_ref with ref.

But that just makes it even weirder that concurrency is being limited on push and workflow_dispatch events both before and after that commit! Makes me wonder if run_id is not being set correctly or something.

Actually, it seems like I might've confused `head_ref` with `ref`. But that just makes it even weirder that concurrency is being limited on `push` and `workflow_dispatch` events both before and after that commit! Makes me wonder if `run_id` is not being set correctly or something.

alexrp commented 2026年01月16日 14:59:48 +01:00

(Note: I've canceled 975 and 976 just to make sure they don't consume CI resources later.)

(Note: I've canceled 975 and 976 just to make sure they don't consume CI resources later.)