Applying agit patches with spaces #2072

ngraves commented 2025年08月08日 11:18:01 +02:00

Big thanks for everything ! This is a copy of guix/guix#899

Following the recommendations from "command line instructions" on: guix/guix#885

graves@precision ~/projects/src/guix-main$ git fetch -u origin +refs/pull/885/head:madage/gnu: mullvadbrowser: Update to 14.5.4 [security-fixes].
fatal : spécificateur de réference invalide : '+refs/pull/885/head:madage/gnu:'

Even with proper quotes :

graves@precision ~/projects/src/guix-main$ git fetch -u origin "+refs/pull/885/head:madage/gnu: mullvadbrowser: Update to 14.5.4 [security-fixes]."
fatal : spécificateur de réference invalide : '+refs/pull/885/head:madage/gnu: mullvadbrowser: Update to 14.5.4 [security-fixes].'

Does that mean that spaces in the agit workflow break the fetching functionality?
I feel either it should fail when users try to upload a branch with spaces, or codeberg should support this usecase.

Big thanks for everything ! This is a copy of https://codeberg.org/guix/guix/issues/899 Following the recommendations from "command line instructions" on: https://codeberg.org/guix/guix/pulls/885 ``` graves@precision ~/projects/src/guix-main$ git fetch -u origin +refs/pull/885/head:madage/gnu: mullvadbrowser: Update to 14.5.4 [security-fixes]. fatal : spécificateur de réference invalide : '+refs/pull/885/head:madage/gnu:' ``` Even with proper quotes : ``` graves@precision ~/projects/src/guix-main$ git fetch -u origin "+refs/pull/885/head:madage/gnu: mullvadbrowser: Update to 14.5.4 [security-fixes]." fatal : spécificateur de réference invalide : '+refs/pull/885/head:madage/gnu: mullvadbrowser: Update to 14.5.4 [security-fixes].' ``` Does that mean that spaces in the agit workflow break the fetching functionality? I feel either it should fail when users try to upload a branch with spaces, or codeberg should support this usecase.

Gusted commented 2025年08月08日 14:04:45 +02:00

@ngraves wrote in #2072 (comment):

I feel either it should fail when users try to upload a branch with spaces, or codeberg should support this usecase

Well, it's bit complicated. There's not really a reason to block spaces (we should be blocking quite some other characters as well in that case) - it's merely a name shown in the UI it's not used internally otherwise. The fetch command should instead be git fetch -u origin +refs/pull/885/head:pr-885 to avoid using the branch name of the Agit PR (that doesn't have the restriction of being a valid git refspec).

@ngraves wrote in https://codeberg.org/Codeberg/Community/issues/2072#issue-2012977: > I feel either it should fail when users try to upload a branch with spaces, or codeberg should support this usecase Well, it's bit complicated. There's not really a reason to block spaces (we should be blocking quite some other characters as well in that case) - it's merely a name shown in the UI it's not used internally otherwise. The fetch command should instead be `git fetch -u origin +refs/pull/885/head:pr-885` to avoid using the branch name of the Agit PR (that doesn't have the restriction of being a valid git refspec).

ngraves commented 2025年08月09日 16:50:50 +02:00

Ty for your quick reply. Could that other option be put in suggestions / command-line instructions, as an alternative maybe ?

Ty for your quick reply. Could that other option be put in suggestions / command-line instructions, as an alternative maybe ?