agit-flow silently fails when not all possible options are specified #2068

tinystar commented 2025年08月06日 20:29:48 +02:00

Comment

so, I've had constant issues using agit-flow to both create new prs and update my prs. though A Lot of trial and error, it seems to be that, even though the forgejo docs say they're optional, if I don't provide a topic and a description, agit-flow will fail silently, with my git client just reporting:

Connection closed by 2a0a:4580:103f:c0de::1 port 22
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

I'm not entirely sure if both a refspec session and the topic option need to be specified at the same time, though every time I was able to push, both were specified.

interestingly, when updating a pr, agit-flow failing due to force-push being necessary does report a proper error. so, presumably, whatever's closing the connection happens after force-push checking in services/agit/agit.go.

### Comment so, I've had constant issues using agit-flow to both create new prs and update my prs. though A Lot of trial and error, it seems to be that, even though the forgejo docs say they're optional, if I don't provide a topic and a description, agit-flow will fail silently, with my git client just reporting: ``` Connection closed by 2a0a:4580:103f:c0de::1 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ``` I'm not entirely sure if both a refspec session and the topic option need to be specified at the same time, though every time I was able to push, both were specified. interestingly, when updating a pr, agit-flow failing due to force-push being necessary does report a proper error. so, presumably, whatever's closing the connection happens after force-push checking in services/agit/agit.go.

Gusted commented 2025年08月06日 20:49:16 +02:00

What git command did you use?

What git command did you use?

tinystar commented 2025年08月06日 21:12:04 +02:00

working commands (hare is existing and needs a force-push, git-config is new):
git push origin HEAD:refs/for/master/git-config -o topic=git-config -o description='migrated from savannah, technically v2.'
git push origin HEAD:refs/for/master -o topic=hare -o title='gnu: packages: Add harelang.' -o description="alr it's changed" -o force-push

broken commands (hare and git-config as above):
git push origin HEAD:refs/for/master/git-config -o topic=git-config -o description='migrated from savannah, technically v2.'
git push origin HEAD:refs/for/master -o topic=git-config -o title='gnu: packages: Fix git system configuration.' -o description='migrated from savannah, technically v2.'
git push origin HEAD:refs/for/master -o topic=git-config -o description='migrated from savannah, technically v2.'
git push origin HEAD:refs/for/master/git-config -o description='migrated from savannah, technically v2.'
git push origin HEAD:refs/for/master/hare -o topic=hare -o title='gnu: packages: Add harelang.' -o description="alr it's changed" -o force-push
git push origin HEAD:refs/for/master/hare -o force-push=true -o title='gnu: packages: Add harelang.'
git push origin HEAD:refs/for/master/hare -o force-push=true -o description="alr it's split"
git push origin HEAD:refs/for/master/hare -o force-push=true

following command logs failure due to force-push being omitted (as expected):
git push origin HEAD:refs/for/master/hare

of note, this is all using ssh

working commands (hare is existing and needs a force-push, git-config is new): `git push origin HEAD:refs/for/master/git-config -o topic=git-config -o description='migrated from savannah, technically v2.'` `git push origin HEAD:refs/for/master -o topic=hare -o title='gnu: packages: Add harelang.' -o description="alr it's changed" -o force-push` broken commands (hare and git-config as above): `git push origin HEAD:refs/for/master/git-config -o topic=git-config -o description='migrated from savannah, technically v2.'` `git push origin HEAD:refs/for/master -o topic=git-config -o title='gnu: packages: Fix git system configuration.' -o description='migrated from savannah, technically v2.'` `git push origin HEAD:refs/for/master -o topic=git-config -o description='migrated from savannah, technically v2.'` `git push origin HEAD:refs/for/master/git-config -o description='migrated from savannah, technically v2.'` `git push origin HEAD:refs/for/master/hare -o topic=hare -o title='gnu: packages: Add harelang.' -o description="alr it's changed" -o force-push` `git push origin HEAD:refs/for/master/hare -o force-push=true -o title='gnu: packages: Add harelang.'` `git push origin HEAD:refs/for/master/hare -o force-push=true -o description="alr it's split"` `git push origin HEAD:refs/for/master/hare -o force-push=true` following command logs failure due to force-push being omitted (as expected): `git push origin HEAD:refs/for/master/hare` of note, this is all using ssh

Gusted commented 2025年08月10日 18:55:39 +02:00

Is this still reproducible? You might have seen SSH fail for other reasons.

Is this still reproducible? You might have seen SSH fail for other reasons.

fnetX commented 2025年08月13日 17:18:41 +02:00

The error messages indicates a network problem. I doubt that the commands even reached Forgejo for AGit processing. I remember there were connectivity issues last week, closing as likely fixed.

The error messages indicates a network problem. I doubt that the commands even reached Forgejo for AGit processing. I remember there were connectivity issues last week, closing as likely fixed.