Internal server error on pull request #1952

Comment

Hi,

Since one hour ago, I am getting a 500 internal server error page on pull requests to the guix/guix repository. Other people also get the message.

See for example guix/guix#118

This doesn’t seem to happen on other repositories.

Could you take a look?

Thanks,
Noé

Hi, was a review request for a team added?

It was probably automatically assigned to team-python by the CODEOWNERS file, yes.

Is it possible this team no longer exists?

It’s possible.

There is a script that deletes all teams and recreates them according to the etc/teams.scm file. Though I don’t know if it has been ran.

Yeah, it's quite likely the 500 is there because the review request references a deleted team.

It’s very likely it has been ran after commit guix/guix@848ebb7f72. Which coincedes with the time that it broke.

CC @civodul

Is there a good way to fix it?

I will try to get a fix in to avoid erroring when this happens. Although another suggestion might be to try and re-use the existing teams, as older PRs will otherwise show "requested review from ghost" or something along those lines.

For sure, we will update the script. Thanks for looking into this!

@Gusted Thanks for the quick feedback.

We maintain our team list and members in a script, which currently blindly deletes and recreates teams as a way to make sure they are in sync with what’s defined in our file.

This seemed to work fine in my limited testing, but I hadn’t realized this could break Forgejo assumptions behind the scenes. I’ll change the script accordingly.

In the meantime, could Forgejo assume that a "ghost team" is equivalent to a same-named team, instead of marking it as ghost?

@civodul wrote in #1952 (comment):

but I hadn’t realized this could break Forgejo assumptions behind the scenes

Forgejo should handle this, this specific code was only touched recently and deleted teams are quite rare.@civodul wrote in #1952 (comment):

In the meantime, could Forgejo assume that a "ghost team" is equivalent to a same-named team, instead of marking it as ghost?

forgejo/forgejo#7987 will describe deleted teams as ghost teams in the requested reviews messages. There's not really a way to recover more information beyond that.

Thanks for coding the fix! Do you have an estimate for when it will be deployed?

We would appreciate if it could go the hotfix way, since it affects about 95 pull requests. And we only moved here 3 days ago!

No pressure though, and thanks again.

Likely tomorrow, no promises.

guix/guix#104 is also broken

Bug fix was deployed on Codeberg.

Thanks a lot! We are so back 😎

P.S. wasn’t it supposed to say "ghost team"? I see no reviews now. No big deal though.

@Baleine wrote in #1952 (comment):

P.S. wasn’t it supposed to say "ghost team"? I see no reviews now. No big deal though.

It's only mentioned in the timeline. The sidebar is a different story.