1
1
Fork
You've already forked BoxBox
0

[FEATURE] Add side menu peeking when using gesture navigation #26

Closed
opened 2022年11月22日 11:41:02 +01:00 by sinfullad · 14 comments
sinfullad commented 2022年11月22日 11:41:02 +01:00 (Migrated from github.com)
Copy link

Is your feature request related to a problem? Please describe.
We should able to swipe open the side menu without needing to disable gesture or tap the hamburger menu

Describe the solution you'd like
Add peeking/swipe at 45° degree to open the side menu, like Infinity for Reddit has.
https://9to5google.com/2019/09/08/android-10-side-hamburger-menus/

Additional context
https://user-images.githubusercontent.com/67637299/203293036-76c26ac1-4740-4b15-b3e6-2d2d144880c9.mp4

**Is your feature request related to a problem? Please describe.** We should able to swipe open the side menu without needing to disable gesture or tap the hamburger menu **Describe the solution you'd like** Add peeking/swipe at 45° degree to open the side menu, like Infinity for Reddit has. https://9to5google.com/2019/09/08/android-10-side-hamburger-menus/ **Additional context** https://user-images.githubusercontent.com/67637299/203293036-76c26ac1-4740-4b15-b3e6-2d2d144880c9.mp4
BrightDV commented 2022年11月27日 17:58:34 +01:00 (Migrated from github.com)
Copy link

It should be fixed by 5c8e90e. You can try it with the apk of c9adc0b (https://github.com/BrightDV/BoxBox/suites/9524675517/artifacts/452477597)

It should be fixed by 5c8e90e. You can try it with the apk of c9adc0b (https://github.com/BrightDV/BoxBox/suites/9524675517/artifacts/452477597)
sinfullad commented 2022年11月27日 18:07:03 +01:00 (Migrated from github.com)
Copy link

It should be fixed by 5c8e90e. You can try it with the apk of c9adc0b (https://github.com/BrightDV/BoxBox/suites/9524675517/artifacts/452477597)

The link doesn't seem to work?

> It should be fixed by 5c8e90e. You can try it with the apk of c9adc0b (https://github.com/BrightDV/BoxBox/suites/9524675517/artifacts/452477597) The link doesn't seem to work?
BrightDV commented 2022年11月27日 19:37:32 +01:00 (Migrated from github.com)
Copy link

Strange... go here, scroll down to Artifacts and then click on app-release.apk. Also, you must be logged in, it is a limitation on GitHub's side.

Strange... go [here](https://github.com/BrightDV/BoxBox/actions/runs/3558306675), scroll down to ` Artifacts` and then click on ` app-release.apk`. Also, you must be logged in, it is a limitation on GitHub's side.
sinfullad commented 2022年11月27日 20:39:20 +01:00 (Migrated from github.com)
Copy link

Strange... go here, scroll down to Artifacts and then click on app-release.apk. Also, you must be logged in, it is a limitation on GitHub's side.

Ok, it works now. I downloaded the latest commit you did, and the swipe works from anywhere now. I got confused at first, expecting it to work like Infinity lol

Also, the one where you fixed the unsupported Atom widget blanked the page for me? Probably needs more time

Screenshot_20221128_023607.jpg

> Strange... go [here](https://github.com/BrightDV/BoxBox/actions/runs/3558306675), scroll down to ` Artifacts` and then click on ` app-release.apk`. Also, you must be logged in, it is a limitation on GitHub's side. Ok, it works now. I downloaded the latest commit you did, and the swipe works from anywhere now. I got confused at first, expecting it to work like Infinity lol Also, the one where you fixed the unsupported Atom widget blanked the page for me? Probably needs more time ![Screenshot_20221128_023607.jpg](https://user-images.githubusercontent.com/67637299/204156038-0b878234-c2f2-4d1f-a438-16a5e51f44ad.jpg)
BrightDV commented 2022年11月29日 19:36:12 +01:00 (Migrated from github.com)
Copy link

Strange... go here, scroll down to Artifacts and then click on app-release.apk. Also, you must be logged in, it is a limitation on GitHub's side.

Ok, it works now. I downloaded the latest commit you did, and the swipe works from anywhere now. I got confused at first, expecting it to work like Infinity lol

Yes, it is more temporary but at least it doesn't work too badly...

Also, the one where you fixed the unsupported Atom widget blanked the page for me? Probably needs more time

I fixed it again in faa70bc, a variable type problem...

> > Strange... go [here](https://github.com/BrightDV/BoxBox/actions/runs/3558306675), scroll down to `Artifacts` and then click on `app-release.apk`. Also, you must be logged in, it is a limitation on GitHub's side. > > Ok, it works now. I downloaded the latest commit you did, and the swipe works from anywhere now. I got confused at first, expecting it to work like Infinity lol Yes, it is more temporary but at least it doesn't work too badly... > Also, the one where you fixed the unsupported Atom widget blanked the page for me? Probably needs more time I fixed it again in faa70bc, a variable type problem...
sinfullad commented 2022年11月30日 00:24:50 +01:00 (Migrated from github.com)
Copy link

Strange... go here, scroll down to Artifacts and then click on app-release.apk. Also, you must be logged in, it is a limitation on GitHub's side.

Ok, it works now. I downloaded the latest commit you did, and the swipe works from anywhere now. I got confused at first, expecting it to work like Infinity lol

Yes, it is more temporary but at least it doesn't work too badly...

Also, the one where you fixed the unsupported Atom widget blanked the page for me? Probably needs more time

I fixed it again in faa70bc, a variable type problem...

Don't worry, your temporary solution is less of a hassle than the official one, especially when I'm using something One Hand Operation+ from Good Lock

Also, the widget is fixed now, but some driver names got buried
Screenshot_20221130_062048.jpg

> > > Strange... go [here](https://github.com/BrightDV/BoxBox/actions/runs/3558306675), scroll down to `Artifacts` and then click on `app-release.apk`. Also, you must be logged in, it is a limitation on GitHub's side. > > > > Ok, it works now. I downloaded the latest commit you did, and the swipe works from anywhere now. I got confused at first, expecting it to work like Infinity lol > > Yes, it is more temporary but at least it doesn't work too badly... > > > Also, the one where you fixed the unsupported Atom widget blanked the page for me? Probably needs more time > > I fixed it again in faa70bc, a variable type problem... Don't worry, your temporary solution is less of a hassle than the official one, especially when I'm using something One Hand Operation+ from Good Lock Also, the widget is fixed now, but some driver names got buried ![Screenshot_20221130_062048.jpg](https://user-images.githubusercontent.com/67637299/204670350-3d3faf1f-eebf-49e6-aa0a-f6407e7c6246.jpg)
BrightDV commented 2022年11月30日 07:53:31 +01:00 (Migrated from github.com)
Copy link

Can you share the link of the article?

Can you share the link of the article?
sinfullad commented 2022年11月30日 07:58:23 +01:00 (Migrated from github.com)
Copy link

Can you share the link of the article?

It's the same article as above.

Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often

https://www.formula1.com/en/latest/article.2023-f1-grid-all-the-drivers-and-teams-racing-next-season.39kWUtoj6oL2HOMcLGO70V.html

> Can you share the link of the article? It's the same article as above. Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often https://www.formula1.com/en/latest/article.2023-f1-grid-all-the-drivers-and-teams-racing-next-season.39kWUtoj6oL2HOMcLGO70V.html
BrightDV commented 2022年11月30日 08:27:18 +01:00 (Migrated from github.com)
Copy link

Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often

It is a good idea, but I can't because it is not implemented on the server side (you can't search on the website). Maybe I can add a button to save/like an article for an easier access.

> Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often It is a good idea, but I can't because it is not implemented on the server side (you can't search on the website). Maybe I can add a button to save/like an article for an easier access.
sinfullad commented 2022年11月30日 08:32:06 +01:00 (Migrated from github.com)
Copy link

Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often

It is a good idea, but I can't because it is not implemented on the server side (you can't search on the website). Maybe I can add a button to save/like an article for an easier access.

While you are at it, how about adding History too?

> > Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often > > It is a good idea, but I can't because it is not implemented on the server side (you can't search on the website). Maybe I can add a button to save/like an article for an easier access. While you are at it, how about adding History too?
BrightDV commented 2022年12月02日 20:06:15 +01:00 (Migrated from github.com)
Copy link

Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often

It is a good idea, but I can't because it is not implemented on the server side (you can't search on the website). Maybe I can add a button to save/like an article for an easier access.

While you are at it, how about adding History too?

Added! Also, I'm closing this as the issue is resolved.

> > > Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often > > > > > > It is a good idea, but I can't because it is not implemented on the server side (you can't search on the website). Maybe I can add a button to save/like an article for an easier access. > > While you are at it, how about adding History too? Added! Also, I'm closing this as the issue is resolved.
BrightDV commented 2022年12月17日 17:36:17 +01:00 (Migrated from github.com)
Copy link

Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often

I added a search functionality using SearXNG and 5 instances to search for articles.
However, the requests are often blocked because of rate limits and the results.

>Also a good time to suggest adding a search function to the app's toolbar, so we don't have scroll through the news as often I added a search functionality using SearXNG and 5 instances to search for articles. However, the requests are often blocked because of rate limits and the results.
sinfullad commented 2022年12月17日 23:15:47 +01:00 (Migrated from github.com)
Copy link

Does the search functionality works just like a normal SearXNG would? How do you filter out other things while searching for F1 articles?

I never tried RSS before, and I don't know if F1's official website allows RSS but I'm wondering whether you can use RSS as a way to store and search articles? If this works, you could also potentially create options add other sources like AMuS in the future, something similar FReader1.

Does the search functionality works just like a normal SearXNG would? How do you filter out other things while searching for F1 articles? I never tried RSS before, and I don't know if F1's official website allows RSS but I'm wondering whether you can use RSS as a way to store and search articles? If this works, you could also potentially create options add other sources like AMuS in the future, something similar FReader1.
BrightDV commented 2022年12月18日 11:43:21 +01:00 (Migrated from github.com)
Copy link

I created an issue for that, see my comment.

I created an issue for that, see [my comment](https://github.com/BrightDV/BoxBox/issues/41#issuecomment-1356770268).
Sign in to join this conversation.
No Branch/Tag specified
main
official-api-support
web-proxy
livetiming-archive
weblate/weblate-box-box-translations
comradekingu/patch-3
v0.3.0
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.0
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BrightDV/BoxBox#26
Reference in a new issue
BrightDV/BoxBox
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?