F-Droid inclusion #1

Poussinou commented 2022年09月24日 12:26:13 +02:00

Hi,

Since this app is GPLv3 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team?

Hi, Since this app is GPLv3 licensed, are you considering the fact to add it to [F-Droid](https://f-droid.org/)? There is a strong community behind. You can find some documentation [here](https://f-droid.org/docs/). Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team?

BrightDV commented 2022年09月24日 15:02:41 +02:00 (Migrated from github.com)

Hi,

Since this app is GPLv3 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team?

I planned to do it, I have made a fastlane folder with screenshots & descriptions. However, I hadn't that much time and I tried to understand how to submit to F-Droid, but I didn't figure it out...
I would agree if someone adds it to F-Droid, but in this case, would I have to do some changes to the repo?

> Hi, > > Since this app is GPLv3 licensed, are you considering the fact to add it to [F-Droid](https://f-droid.org/)? There is a strong community behind. > > You can find some documentation [here](https://f-droid.org/docs/). > > Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team? I planned to do it, I have made a [fastlane folder with screenshots & descriptions.](https://github.com/BrightDV/BoxBox/tree/main/fastlane/metadata/android) However, I hadn't that much time and I tried to understand how to submit to F-Droid, but I didn't figure it out... I would agree if someone adds it to F-Droid, but in this case, would I have to do some changes to the repo?

Poussinou commented 2022年09月24日 22:54:28 +02:00

I started the process by opening a Request For Packaging.

Our F-Droid bot will scan this repo and tell us some information, and we'll see if something is needed. Otherwise we can move forward and submit the app to the repo here.

I started the process by opening a [Request For Packaging](https://gitlab.com/fdroid/rfp/-/issues/2219). Our F-Droid bot will scan this repo and tell us some information, and we'll see if something is needed. Otherwise we can move forward and submit the app to the repo [here](https://gitlab.com/fdroid/fdroiddata).

licaon-kter commented 2022年09月27日 16:43:04 +02:00 (Migrated from github.com)

;) pls test https://gitlab.com/fdroid/rfp/-/issues/2219#note_1116002503

And a small request: can the "Check Update" menu entry be removed? Makes no sense for F-Droid.

;) pls test https://gitlab.com/fdroid/rfp/-/issues/2219#note_1116002503 And a small request: can the "Check Update" menu entry be removed? Makes no sense for F-Droid.

BrightDV commented 2022年09月27日 20:20:15 +02:00 (Migrated from github.com)

Thanks a lot for the work!
I added the latest changelog to the fastlane folder and the metadata file on GitLab looks good to me.

And a small request: can the "Check Update" menu entry be removed? Makes no sense for F-Droid.

Do you mean the button in the settings? If so, it is for users who want a faster update or who do not have F-Droid, like NewPipe does.

Thanks a lot for the work! I added the latest changelog to the fastlane folder and the metadata file on GitLab looks good to me. > And a small request: can the "Check Update" menu entry be removed? Makes no sense for F-Droid. Do you mean the button in the settings? If so, it is for users who want a faster update or who do not have F-Droid, like NewPipe does.

licaon-kter commented 2022年09月27日 20:49:50 +02:00 (Migrated from github.com)

@BrightDV yes, but I'd like to remove that useless entry, as users can't really update to your version since this app is not build reproducible, right?

Maybe you have a bit of sed magic that we can apply before build? :)

@BrightDV yes, but I'd like to remove that useless entry, as users can't really update to your version since this app is not build reproducible, right? Maybe you have a bit of `sed` magic that we can apply before build? :)

BrightDV commented 2022年09月27日 20:54:47 +02:00 (Migrated from github.com)

What do you mean by build reproducible?

What do you mean by build reproducible?

licaon-kter commented 2022年09月27日 21:34:03 +02:00 (Migrated from github.com)

https://f-droid.org/docs/Reproducible_Builds/

https://f-droid.org/docs/Reproducible_Builds/

BrightDV commented 2022年09月27日 21:51:18 +02:00 (Migrated from github.com)

So as I saw, you need my signing key? For the first releases, I hadn't a signing key, but since v0.0.3 I use one, with apksigner.
Is this file what is needed to make builds reproducibles?
Sorry if I misunderstand...

So as I saw, you need my signing key? For the first releases, I hadn't a signing key, but since v0.0.3 I use one, with `apksigner`. Is this file what is needed to make builds reproducibles? Sorry if I misunderstand...

licaon-kter commented 2022年09月28日 09:36:39 +02:00 (Migrated from github.com)

No, basically F-Droid builds the APK, it compares it to your APK for this version, if they are identical then F-Droid uses your APK directly (with your signature). There's no extra signing, F-Droid does not need your key, etc.

just that it is hard to make your app build reproducible, hence there are fewer of them.

When this happens users can update to your APKs so the update function makes sense. Else... it does not, it will just confuse the users.

No, basically F-Droid builds the APK, it compares it to your APK for this version, if they are identical then F-Droid uses your APK directly (with your signature). There's no extra signing, F-Droid does not need your key, etc. just that it is hard to make your app build reproducible, hence there are fewer of them. When this happens users can update to your APKs so the update function makes sense. Else... it does not, it will just confuse the users.

BrightDV commented 2022年09月28日 20:02:49 +02:00 (Migrated from github.com)

So as you asked, I removed the entry for update check.
Do I need to do anything else?

So as you asked, I removed the entry for update check. Do I need to do anything else?

licaon-kter commented 2022年09月28日 20:21:05 +02:00 (Migrated from github.com)

I guess not, I'l rebuild asap to verify, thanks.

I guess not, I'l rebuild asap to verify, thanks.

licaon-kter commented 2022年09月30日 11:25:45 +02:00 (Migrated from github.com)

Looking good!

Looking good!

licaon-kter commented 2022年09月30日 12:44:39 +02:00 (Migrated from github.com)

/close this ; ) gitlab.com/fdroid/fdroiddata/-@4fc24e20ed

/close this ; ) https://gitlab.com/fdroid/fdroiddata/-/commit/4fc24e20edfcf21e2d5a7df12757298704e61b6c

BrightDV commented 2022年09月30日 18:47:04 +02:00 (Migrated from github.com)

Thanks a lot!

Thanks a lot!