Fix incorrect Poppler version check

Author: KrIr17
Author Date: 2026年07月06日 11:55:08 UTC

Fix incorrect Poppler version check

1ad89c941bad5e42a3378cd8644a4c4cd3b6ea71 adapts to changes in Poppler
26.06.0, so that should what be the version we check for.

Identified by @PBS in https://gitlab.com/inkscape/inkscape/-/merge_requests/7968#note_3526749691

update translations

Author: Inkscape
Author Date: 2026年07月01日 02:22:10 UTC

update translations

Fix PPA and Snap packaging

Author: PBS
Author Date: 2026年02月24日 13:53:57 UTC

Fix PPA and Snap packaging

* PPA builds are failing due to test failures. Fix as many of them as
possible (all of them on amd64), then make them non-fatal anyway.

* Snap builds are failing due to copying non-existent libcapypdf.so.

Set full opacity for text in latex-pdf output

Author: Michael Terry
Author Date: 2026年06月11日 13:34:42 UTC

Set full opacity for text in latex-pdf output

It was previously accidentally set to fully transparent.

Fixes https://gitlab.com/inkscape/inkscape/-/work_items/5626

Fix pasting of most formats on Windows

Author: Michael Terry
Author Date: 2026年05月28日 18:33:07 UTC

Fix pasting of most formats on Windows

But break pasting CF_ENHMETAFILE in the meantime. This is an
intentional regression for the time being, to get a fix in for the
rest of the clipboard targets.

Fixes https://gitlab.com/inkscape/inkscape/-/work_items/6097

Fix inverse mask disappearing when moved

Author: Michael Terry
Author Date: 2026年05月24日 19:23:50 UTC

Fix inverse mask disappearing when moved

We were trying to detach and re-attach the mask when moved, but trying
to reattach it to a URI that was only saved in one code path.

Rather than rely on a possibly stale URI, just grab the URI right
before detaching, and re-attach to that spot. Then we can drop the
saved URI altogether.

Some tests had to be updated as part of this, because previously, the
mask bounding boxes paths were never being updated as part of the test
since the mask was getting internally deleted. And since there's been
drift over the years on these tests, the bounding boxes were one or two
pixels offset, which failed the tests. So I updated the tests to what
Inkscape writes out these days (which involves lots of little updates
in the file).

Fixes https://gitlab.com/inkscape/inkscape/-/work_items/6154

Open dialogs a little later during startup

Author: Michael Terry
Author Date: 2026年05月19日 14:11:53 UTC

Open dialogs a little later during startup

Actually fix date order >_<

Author: Marc Jeanmougin
Author Date: 2026年04月27日 12:22:08 UTC

Actually fix date order >_<

update translations (ru)

Author: slichtzzz
Author Date: 2025年10月30日 09:01:21 UTC

update translations (ru)

Revert "Update Simplified Chinese (zh_CN) translation to 100%"

Author: Willy (Wen-Wei) Kao
Author Date: 2025年10月29日 04:29:27 UTC

Revert "Update Simplified Chinese (zh_CN) translation to 100%"

This reverts commit 7fddddd83ecebaf2ee8e6ef7ac7b204ed37ec9ca

Translated using Weblate (Romanian)

Author: Cristian Secară
Author Date: 2025年08月19日 15:59:38 UTC

Translated using Weblate (Romanian)

Currently translated at 79.7% (8657 of 10857 strings)

Translation: Inkscape/1.4.x
Translate-URL: https://translate.inkscape.org/projects/inkscape/1-4-x/ro/

Update file align-and-distribute.cpp

Author: Adam Belis
Author Date: 2025年07月27日 09:55:36 UTC

Update file align-and-distribute.cpp

debug test commit

Author: Max Gaukler
Author Date: 2025年04月20日 15:21:09 UTC

debug test commit

Twitter to X

Author: sushant.co19
Author Date: 2024年11月30日 09:29:01 UTC

Twitter to X

Fix test_colors_xml test.

Author: Shlomi Fish
Author Date: 2024年09月20日 04:20:46 UTC

Fix test_colors_xml test.

The icc="" digest was out-of-date.

To avoid freezes, don't check if recent files exist

Author: Max Gaukler
Author Date: 2024年03月07日 19:45:25 UTC

To avoid freezes, don't check if recent files exist

Backport of MR https://gitlab.com/inkscape/inkscape/-/merge_requests/6294 as bugfix for https://gitlab.com/inkscape/inkscape/-/issues/2348

WIP: gtk4 Windows test run

Author: René de Hesselle
Author Date: 2024年01月07日 13:00:16 UTC

WIP: gtk4 Windows test run

Backport MR 5831 - Fix Knot crashes in LPES

Author: Jabiertxof
Author Date: 2023年10月24日 10:00:55 UTC

Backport MR 5831 - Fix Knot crashes in LPES

Update rules

Author: Marc Jeanmougin
Author Date: 2023年10月13日 13:07:49 UTC

Update rules

color-palette: Don't use per-widget style provider

Author: Daniel Boles
Author Date: 2023年07月28日 11:15:39 UTC

color-palette: Don't use per-widget style provider

Those are deprecated in GTK4 and often 'work' surprisingly in GTK3/4
anyway (they don't cascade, you know, like Cascading Style Sheets...)
and in this case it appears trivial to move them to share/ui/style.css

dialog/objects: Centre blendModePopup() + cleanups

Author: Daniel Boles
Author Date: 2023年07月27日 16:52:19 UTC

dialog/objects: Centre blendModePopup() + cleanups

When reviewing the Controller MR, Mike was bemused that the blend mode
popover opens wherever the pointer was. It was already thus! But it is
fairly easy to always point to the middle of the icon, so do so; hence
it is consistent where we pop up, & we don't obscure the context icon.

* Factor out from getting the expander x to get_cell_area() -> rectangle
* Use it to get cell area for blend mode icon. Change to popup at middle
* Use Controller::has_flag() to more clearly check for pressed modifiers

Update cairo patch

Author: Marc Jeanmougin
Author Date: 2023年05月25日 23:39:54 UTC

Update cairo patch

Restore/enlarge size of on-canvas text

Author: Nathan Lee
Author Date: 2022年12月08日 13:51:07 UTC

Restore/enlarge size of on-canvas text

Follow-up of 05ea6169e29eb23079f0a32f83f82606604bcf86

Fix build with Poppler 22.09.0

Author: Sam James
Author Date: 2022年09月06日 10:10:25 UTC

Fix build with Poppler 22.09.0

Adapt to changes in Poppler's getLineDash/setLineDash interface to allow building with Poppler 22.09.0.

...

Author: Jabier Arraiza
Author Date: 2022年09月01日 22:35:03 UTC

...

Update FAKETONE.gpl

Author: Adam Belis
Author Date: 2022年07月21日 18:04:22 UTC

Update FAKETONE.gpl

Hide LPE tool for 1.2.0

Author: Jabier Arraiza
Author Date: 2022年05月13日 15:57:30 UTC

Hide LPE tool for 1.2.0

Clear stale reference document pointer

Author: Thomas Holder
Author Date: 2022年01月27日 07:12:48 UTC

Clear stale reference document pointer

Fix build with poppler 21.11.0

Author: Evangelos Foutras
Author Date: 2021年11月01日 19:45:38 UTC

Fix build with poppler 21.11.0

GfxFont::tag is now of type std::string instead of GooString *.

Make _cmp::operator() const

Author: Thomas Holder
Author Date: 2021年12月24日 15:15:43 UTC

Make _cmp::operator() const

Fixes "static assertion failed: comparison object must be invocable as
const" on Arch Linux with GCC 11.1.0.

fix a issue when user configure a theme with low contrast

Author: Jabier Arraiza
Author Date: 2021年05月16日 19:45:14 UTC

fix a issue when user configure a theme with low contrast

(cherry picked from commit 1c35b443f69c156c503d682a18f92b9a0a4a003e)

decrease back to 1000

Author: Adam Belis
Author Date: 2021年05月03日 11:57:38 UTC

decrease back to 1000

This MR fix rendering of rubberband and bbox of selected items

Author: Jabier Arraiza
Author Date: 2021年04月24日 11:33:21 UTC

This MR fix rendering of rubberband and bbox of selected items

Because now background is isolated from content we need to render the lines with background behaind
Fixes issue https://gitlab.com/inkscape/inkscape/-/issues/2352

(cherry picked from commit 7f462d36a2988e6475162a5e8d1ed3760e857ca3)

When for example crate a text, convert to paths and do ofset, inset is super ...

Author: Jabier Arraiza
Author Date: 2021年04月25日 14:40:13 UTC

When for example crate a text, convert to paths and do ofset, inset is super slow
This is because threshols of simplify is bad defined.

(cherry picked from commit 230788820cf8596897a71bf0784b6ece57776bc7)

Fix Blur remove on blend change

Author: Anshudhar
Author Date: 2021年03月26日 10:44:49 UTC

Fix Blur remove on blend change

(cherry picked from commit 17bc918465838f8438cb5df602040f2945bfb276)

This add a system to test LPE based in data of paths

Author: Jabier Arraiza
Author Date: 2021年02月14日 16:02:47 UTC

This add a system to test LPE based in data of paths

Because inkscape recreate the d atribute on run from comand line we use
this feature to store the same version with and without d atribute and check
the new generated d attributes are equal original ones.

Install themes to $prefix/share/themes

Author: Thomas Holder
Author Date: 2021年01月01日 16:54:23 UTC

Install themes to $prefix/share/themes

Add XDG_DATA_DIRS to AppRun for custom themes

Testing phase

Author: Jabier Arraiza
Author Date: 2020年11月22日 21:12:48 UTC

Testing phase

Remove toCurves from combine and breakapart

Author: Jabier Arraiza
Author Date: 2020年10月17日 20:36:44 UTC

Remove toCurves from combine and breakapart

Fix the issue:
inkscape:548 https://gitlab.com/inkscape/inkscape/-/issues/548

(cherry picked from commit 37b819daafd2e1612dca7a1df74710ea8ff2487e)

Remove to curves from verbs on boolops operations

Author: Jabier Arraiza
Author Date: 2020年10月17日 20:27:05 UTC

Remove to curves from verbs on boolops operations

Fix issue:
inkscape#589 https://gitlab.com/inkscape/inkscape/-/issues/589

(cherry picked from commit 53d95db01e5046287ad6feb24a262740550dee1d)

Remove toCurves from reverse path

Author: Jabier Arraiza
Author Date: 2020年10月16日 23:54:24 UTC

Remove toCurves from reverse path

No neded, clones not neeed to be reversed if parent dont change and LPE is reversed ok without it

(cherry picked from commit b33c89181a261c99f51da0e3a887b239bc732c0a)

Mirror symmetry currenty has some problems with some situations so sometimes ...

Author: Jabier Arraiza
Author Date: 2020年10月02日 23:45:44 UTC

Mirror symmetry currenty has some problems with some situations so sometimes it create closed paths and other open ones over the split line
To fix it we add a versioning to now broke existing works
And handle correctly in the future (I select the most often situation that is close the path)

This fix is targeted for 1.0.2 for 1.1 I do another tweak that allow open and closed paths over the split line.

Change Gio::Action 'transform-translate' to use a tuple Glib::Variant (dd).

Author: Tavmjong Bah
Author Date: 2020年09月23日 18:35:51 UTC

Change Gio::Action 'transform-translate' to use a tuple Glib::Variant (dd).

Fix #1815 with correct activation checks

Author: Martin Owens
Author Date: 2020年08月26日 09:09:34 UTC

Fix #1815 with correct activation checks

Speedup LPEś file load

Author: Jabier Arraiza
Author Date: 2020年08月18日 05:45:00 UTC

Speedup LPEś file load

With this MR SPPath is not recalculated and use last value on save, with SPGroups and SPShapes we reduce the LPE process from 2 blocks to 1.(2->0 for paths)

(cherry picked from commit 22628fedec3f2e69c4007a5877640b35962b0652)

Avoid using GObject data

Author: Alex Valavanis
Author Date: 2020年08月17日 12:37:54 UTC

Avoid using GObject data

Move snap toggles to verbs and combine icon info.

Author: Martin Owens
Author Date: 2020年08月16日 07:58:46 UTC

Move snap toggles to verbs and combine icon info.

Fix license header

Author: Alex Valavanis
Author Date: 2020年06月28日 20:13:28 UTC

Fix license header

CalligraphyToolbar: Gtkmmify

Author: Alex Valavanis
Author Date: 2020年06月23日 19:00:13 UTC

CalligraphyToolbar: Gtkmmify

fix attributes test

Author: Thomas Holder
Author Date: 2020年05月04日 14:38:42 UTC

fix attributes test

Fix issue Inkscape 125 and 686 - Toolbar empty after startup https://gitlab.c...

Author: Jabier Arraiza
Author Date: 2020年04月29日 18:01:59 UTC

Fix issue Inkscape 125 and 686 - Toolbar empty after startup https://gitlab.com/inkscape/inkscape/-/issues/125 Some comboboxes in tool settings hidden for small window; do not appear in drop-down menu https://gitlab.com/inkscape/inkscape/-/issues/686

(cherry picked from commit 22729a42adc9b26660ba4316587ce0f58deff432)

Ignore flowPara without children to be consistent with rendering in previous ...

Author: Mc
Author Date: 2020年04月29日 13:13:52 UTC

Ignore flowPara without children to be consistent with rendering in previous Inkscape versions

Fixes part of https://gitlab.com/inkscape/inkscape/-/issues/1349

(cherry picked from commit e0dd6e42d9cb14326f2fb04512ed16b1512f0c72)

Quick for 'inline-size' editting bug (entering a 'new-line' results in splitt...

Author: Tavmjong Bah
Author Date: 2020年04月25日 11:30:35 UTC

Quick for 'inline-size' editting bug (entering a 'new-line' results in splitting text element).

Convert plain text to multi-line text on "Enter".

Author: Tavmjong Bah
Author Date: 2020年04月20日 10:35:33 UTC

Convert plain text to multi-line text on "Enter".
Fixes https://gitlab.com/inkscape/inkscape/-/issues/730

(cherry picked from commit d42f29923cd4343bb1965178aebdcc000346555e)

Enable justified text option in toolbar for SVG2 text in shape.

Author: Tavmjong Bah
Author Date: 2020年04月17日 11:48:24 UTC

Enable justified text option in toolbar for SVG2 text in shape.

(cherry picked from commit 10325e91998a8323a32acd527009cd89e0da7176)

Line height change unit preserve current text line height status

Author: Jabiertxof
Author Date: 2020年04月20日 21:42:02 UTC

Line height change unit preserve current text line height status
Not change visual line height when only change units

We currently have two type of text selection, inner and outer.
Outer one or more text items selected or one with cursor focus on it.
Inner is when there is a selection on the text (some letters on blue).

When we are in outer mode and change line height, it remove all child line height and apply to root node.
When we are in inline mode we move the root line height to all lines of the element with line height below, except
the ones in the subselecton that take the value changed.

To fix it, on selection change, set the cursor line affected also in outer mode.
On line height unit change, we check for the case one item selected with line height == 0. If it happends,
only on unit change we bypass outer code and thread as inner, that give no visual changes.

(cherry picked from commit 91f032153bbd8dce16ede2cb9796ae5f1e95eebc)

Add g_warnigns to understand CRs issues

Author: Martin Owens
Author Date: 2020年04月17日 04:13:34 UTC

Add g_warnigns to understand CRs issues

fix #1279 crash on image import

Author: Thomas Holder
Author Date: 2020年04月13日 09:19:50 UTC

fix #1279 crash on image import

Regression of 3274e7a12296

Boolops LPE.

Author: Jabiertxof
Author Date: 2020年04月13日 20:22:12 UTC

Boolops LPE.
New boolops options cut inside and cut outside are broken need to be fixed for 1.1
I remove it comenting, also fix some issues about wrong division operation based in a sugestion I found in the code of sp_pathvector_boolop

(cherry picked from commit 86f4e6977c6778f2ce460bb629e1b4bc750e4103)

remove python-dev (not present on focal)

Author: Marc Jeanmougin
Author Date: 2020年04月11日 14:03:37 UTC

remove python-dev (not present on focal)

Fix icons issues

Author: Jabiertxof
Author Date: 2020年04月05日 22:54:07 UTC

Fix icons issues

Partial fix for https://gitlab.com/inkscape/inkscape/-/issues/125

Author: Jabiertxof
Author Date: 2020年04月03日 00:07:19 UTC

Partial fix for https://gitlab.com/inkscape/inkscape/-/issues/125

More fixes to undo on LPE

Author: Jabiertxof
Author Date: 2020年04月02日 22:42:23 UTC

More fixes to undo on LPE

(cherry picked from commit 05e9e8ed4a3319d21ec22bbc21b375718505872b)

Hide prefear dark theme button if the theme don't has it, also remove system ...

Author: Jabiertxof
Author Date: 2020年04月01日 21:46:54 UTC

Hide prefear dark theme button if the theme don't has it, also remove system wide theme and icons from theming UI dropdowns relaiyng on system default option

test

Author: Jabiertxof
Author Date: 2020年03月31日 00:27:05 UTC

test

Remove prefear dark theme from UI

Author: Jabiertxof
Author Date: 2020年03月30日 20:57:32 UTC

Remove prefear dark theme from UI

Reorder tools to allow visualize zoom tool in small screens hidden since last...

Author: Jabier Arraiza
Author Date: 2020年03月23日 09:34:34 UTC

Reorder tools to allow visualize zoom tool in small screens hidden since last refactor

(cherry picked from commit d0d3c000d41eca5efc1661566afc1506e954241c)

Fix toolbar icons on theme adwaita too much pading and fix diferent from one ...

Author: Jabier Arraiza
Author Date: 2020年03月23日 11:01:12 UTC

Fix toolbar icons on theme adwaita too much pading and fix diferent from one toolbar to other (tools - snap)

Start work. Goal remove maximun of unoptimiced forced transforms and provide ...

Author: Jabier Arraiza
Author Date: 2020年03月23日 09:06:07 UTC

Start work. Goal remove maximun of unoptimiced forced transforms and provide a way to full control transforms from LPE

Fix scrolling rendering issues

Author: Jabiertxof
Author Date: 2020年03月09日 18:07:14 UTC

Fix scrolling rendering issues

Shape bbox translation speedup

Author: Martin Owens
Author Date: 2020年02月02日 11:25:02 UTC

Shape bbox translation speedup

(cherry picked from commit e997ca1f1f266167017d4580af9e3c18f9ab53e1)

Small try to improve rendering rendering objects in one pass

Author: Jabier Arraiza
Author Date: 2020年02月22日 16:00:29 UTC

Small try to improve rendering rendering objects in one pass

Fix Text tool scroll leaves some background items unrendered inbox#1397

Author: Jabiertxof
Author Date: 2020年02月15日 09:16:10 UTC

Fix Text tool scroll leaves some background items unrendered inbox#1397

Increase size of about screen to 80% and remove icon.

Author: Martin Owens
Author Date: 2019年12月31日 00:00:00 UTC

Increase size of about screen to 80% and remove icon.

(cherry picked from commit 1fceb22ce155054bada4be3c28f2d92f90fa3c14)

Fix #771 only update markers on style changes

Author: Martin Owens
Author Date: 2020年02月04日 19:58:19 UTC

Fix #771 only update markers on style changes

Fix #761 Save any extra text at the end of the layout into a hidden tspan dur...

Author: Martin Owens
Author Date: 2020年01月24日 10:56:21 UTC

Fix #761 Save any extra text at the end of the layout into a hidden tspan during fallback conversion.

Turn text fallback off for Inkscape 1.0

Author: Martin Owens
Author Date: 2020年01月24日 17:15:00 UTC

Turn text fallback off for Inkscape 1.0

Fix #471 by calculating the number of segments needed in arc conversions.

Author: Martin Owens
Author Date: 2020年01月22日 18:04:30 UTC

Fix #471 by calculating the number of segments needed in arc conversions.

(cherry picked from commit 3d477663832380783b6cb18d5bc3a8cd9b1e7869)

Fix text+shape_inside duplicate/copy

Author: Iskren Ivov Chernev
Author Date: 2019年12月30日 17:26:36 UTC

Fix text+shape_inside duplicate/copy

Text can be flown into shapes (via the shape-inside style property), and
these need special attention during duplicate/copy. These shapes need to
be duplicated/copied in addition to the text, in case they are not
included in the dupe/copy selection already.

For duplication -- if a text object references shapes via
shape-inside/shape-subtract they are added to the duplicate selection
(if not present).

For layer duplication -- if a text in the duplicated layer references
shapes outside of its layer, these shapes are duplicated and brought
into the new layer.

For copy -- if a text object references shapes they are added to the
generated clipboard document (if not selected already). After the
clipboard is pasted, some ids might need change (to prevent clashes), so
the existing id clash prevention logic is augmented to mind text shapes
as well.

Rough edges (not directly related to copy/duplicate):
- explicit shape-inside is not well handled in the UI
- shape might end up on top of text
- Select & Transform tool changes the relative position of the text
and its shapes
- during paste shift logic (so pasted stuff is not on top of
original), the transformation on text object causes it to jump
outside of the shape (and it might be too far off / not visible) --
bad UX.
- shape and text being on separate layers doesn't fire update
text layout when shape is changed, but somehow snaps text into shape
when a text transform is applied
- shape-subtract handling is not implemented at all
- basic-shapes are not handled in shape-inside

(cherry picked from commit 95f17f34521466fb2f329c07c3289eaa20348605)

Repair bad regex and copy shape-inside reference correctly.

Author: Martin Owens
Author Date: 2020年01月23日 16:48:00 UTC

Repair bad regex and copy shape-inside reference correctly.

Add doxygen comments and shall_write is a real

Author: Martin Owens
Author Date: 2020年01月13日 14:52:01 UTC

Add doxygen comments and shall_write is a real

Add @speleo3 patch

Author: Jabier Arraiza
Author Date: 2020年01月12日 16:24:48 UTC

Add @speleo3 patch

AVAILABLE_MAC_OS_X_VERSION_10_12_AND_LATER

Author: Thomas Holder
Author Date: 2020年01月10日 20:15:29 UTC

AVAILABLE_MAC_OS_X_VERSION_10_12_AND_LATER

Constrain variable cache limit to zoom or panning

Author: Jabier Arraiza
Author Date: 2019年12月20日 12:10:18 UTC

Constrain variable cache limit to zoom or panning

(cherry picked from commit 59dabc7d8dc0f93761412075dd00bec96b0c55e5)

Working with Windows10 Theme

Author: Jabier Arraiza
Author Date: 2019年12月06日 09:52:03 UTC

Working with Windows10 Theme

Disable test (until CI updated to newer Pango).

Author: Tavmjong Bah
Author Date: 2019年12月06日 09:47:36 UTC

Disable test (until CI updated to newer Pango).

Try to build on windows again

Author: Jabiertxof
Author Date: 2019年12月05日 12:12:18 UTC

Try to build on windows again

Crash fix, but now --convert-dpi-method interactiv

Author: Shlomi Fish
Author Date: 2019年11月30日 14:54:23 UTC

Crash fix, but now --convert-dpi-method interactiv

fix compiling

Author: Jabier Arraiza
Author Date: 2019年11月13日 18:05:10 UTC

fix compiling

Add profiling define

Author: Jabiertxof
Author Date: 2019年11月11日 09:46:55 UTC

Add profiling define

Remove duplicate function left after last forced merge.

Author: Tavmjong Bah
Author Date: 2019年11月05日 12:19:37 UTC

Remove duplicate function left after last forced merge.

Fix issue with system icons in KDE plasme https://gitlab.com/inkscape/inkscap...

Author: Jabiertxof
Author Date: 2019年09月27日 11:38:29 UTC

Fix issue with system icons in KDE plasme https://gitlab.com/inkscape/inkscape/issues/431

Fix conflicts in "Ship Inkscape with themes option A" MR

Author: Jabiertxof
Author Date: 2019年09月20日 08:06:43 UTC

Fix conflicts in "Ship Inkscape with themes option A" MR

Add code from old MR 811

Author: Jabier Arraiza
Author Date: 2019年08月04日 11:01:25 UTC

Add code from old MR 811

fix #406 pinch zoom crashes macOS 10.9

Author: Thomas Holder
Author Date: 2019年09月10日 08:13:40 UTC

fix #406 pinch zoom crashes macOS 10.9

Fix issue

Author: Martin Owens
Author Date: 2019年09月07日 21:28:56 UTC

Fix issue

Remove pot files from the main repository to move towards better control

Author: Martin Owens
Author Date: 2019年08月09日 21:52:57 UTC

Remove pot files from the main repository to move towards better control

add hamburger line height menu

Author: Jabier Arraiza
Author Date: 2019年06月26日 18:35:19 UTC

add hamburger line height menu

attemp to use SVG data wrong by double rounding issues

Author: Jabier Arraiza
Author Date: 2019年06月27日 22:40:11 UTC

attemp to use SVG data wrong by double rounding issues

fix wrong default value

Author: Jabier Arraiza
Author Date: 2019年06月23日 21:16:13 UTC

fix wrong default value