Launcher does not respond to changes in icon theme

Bug Description

[Test Case]
1. Open a terminal
2. Open the system settings
3. Change the icon theme from Ambience to High Constrast
-> Verify the icon of the terminal is updated

[Regression Potential]
No regression potential, no existing code modified.

Original description:

The Launcher should refresh its icons when the icon theme is changed.

If possible, crossfade between the old tile and the new tile.

Initially, I thought I had solved the problem, but sometimes compiz breaks suddenly.

It seems that a LauncherIcon is with a very strange icon name (it's not a string). When trying to reload it to match the new theme, compiz crashes.

Anyway, I'm uploading the code to a branch. Could someone test it?

Any progress updates?

What I've tried: connect a GtkIconTheme changed signal with a method that reloads the icon (in practice, it was setting the icon name as the same as before. This way, the icon was reloaded from file - therefore, reflecting icon theme change).

But, Unity 3.6 and 3.6.2 were crashing sometimes when I changed the icon theme. It looks like that a pointer to a SimpleLauncherIcon does not contains exactly a SimpleLauncherIcon... I haven't too much skills on C++, but there is something wrong.

I'll try to do it again today with the latest trunk version.

Same problem with revision 945. Could someone apply the patch I'm attaching and test, please?

This bug was fixed in the package unity - 3.6.8-0ubuntu1

---------------
unity (3.6.8-0ubuntu1) natty; urgency=low

* New upstream release.
- crash at the second drag and drop from an unity place (LP: #736704)
- Compiz crashes with SIGSEGV in nux::GraphicsDisplay::GrabPointer when
opening the Dash (LP: #737287)
- Visual Tearing/Rendering Issues with Unity Launcher (LP: #737476)
- unity-window-decorator crash on unity panel dragout (LP: #740480)
- unity-panel-service crashed with SIGSEGV in g_type_check_instance_is_a()
(LP: #694699)
- compiz crashed with SIGSEGV in nux::BaseTexture::GetDeviceTexture()
(LP: #692823)
- the "no result" and "search the web" items need icons (LP: #711199)
- Resizing with external padding/grab area prevents reaching edge of
screen (LP: #710356)
- drag and drop of launcher icons uses microscopic drag icon (LP: #727647)
- text in places look squeezed (LP: #727799)
- at-spi-registry consumes most of the CPU and make the system unusable on
Natty (LP: #729827)
- migrate_favorites.py crashed with GError in __main__: Bad key or
directory name: "/desktop/unity/launcher/favorites/app-
dc++.desktop/type": `+' is an invalid character in key/directory names
(LP: #737016)
- Launcher hide state is confusing (LP: #739850)
- Polish new launcher hide state (part 2) (LP: #740020)
- launcher icons should expan on super or when entering keynav
(LP: #741319)
- Launcher - Dragging a Launcher icon to the Trash should remove the icon
(LP: #676466)
- Launcher - Enable dragging and dropping of files & folders to Launcher
icons (LP: #676549)
- Dash - Add Dash group header mouseover effect (LP: #689640)
- unity aborts when you plug in an external monitor (LP: #700757)
- Keyboard-navigation: focus on launcher remembered (LP: #713340)
- Launcher Quicklists should always contain the application title
(LP: #723877)
- When a maximized window has window on top of it in 'restored state' (not
maximised) , it is not possible to un-maximized the window by dragging
the title bar downwards (LP: #723882)
- When windows open for the first time they should not hide the launcher
(LP: #723878)
- UI blocked when expanding a section with more than 2000 items
(LP: #736059)
- Change ALT-Tab to bring the target window to the front (LP: #736938)
- compiz crashed with SIGABRT in __kernel_vsyscall() (LP: #737814)
- Launcher does not respond to changes in icon theme (LP: #605475)
- Implement new style scrollbars in Dash (LP: #608124)
- Closing launcher menu raises window under mouse (LP: #728787)
- adding url launcher support from the search (LP: #739038)
- Launcher - Set Launcher 'Hide Animation' to 'Slide only' by default.
Also introduce subtle fade in effect. (LP: #739567)
- "Time & Date" settings appears in launcher with empty tooltip
(LP: #740907)
- ZeitgeistLog missing implementation of get_property for "connected"
(LP: #734080)
- often can't alt-click-dnd to move the focussed dialog (LP: #711911)
- The Unity P...

Hello David, or anyone else affected,

Accepted unity-2d into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/unity-2d/5.14.0-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Verified on my precise system - icons change as expected.

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

This bug was fixed in the package unity-2d - 5.14.0-0ubuntu1

---------------
unity-2d (5.14.0-0ubuntu1) precise-proposed; urgency=low

* New upstream release (LP: #1060262):
- [Launcher] [Multi-monitor] Removing a non running app tile from a
launcher should remove it from all (LP: #988739)
- Panel Titlebar double click is emitted for any mouse button (LP: #736491)
- Launcher does not hide if shown while dragging a file (LP: #1002308)
- icon isn't reset when clearing the search query (LP: #973225)
- Issue when ejecting busy device from the Unity 2D Shell (LP: #997786)
- Sticky edges don't work in RTL (LP: #984092)
- pips are not correctly updated when plugin in a second monitor
(LP: #1003943)
- [dash] Unable to maximize (LP: #918648)
- all panels have same window focus on multiple monitors unity2d
(LP: #930147)
- Dash will not open files under Greek folders (LP: #1002710)
- Launcher does not respond to changes in icon theme (LP: #605475)
- [panel] Invisible items in systray (LP: #703389)
- [panel] Ignores "enabled" property on top-level menus (LP: #850017)
* Reverted some quantal-specific commits which are no longer relevant
-- Lukasz 'sil2100' Zemczak <email address hidden> 2012年10月30日 09:59:49 +0100