Message 99385 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	eric.araujo
Recipients	andrewclegg, eric.araujo
Date	2010年02月16日.05:02:10
SpamBayes Score	3.5640915e-09
Marked as misclassified	No
Message-id	<1266296532.89.0.195780253421.issue7846@psf.upfronthosting.co.za>

Content
Hello The feature seems useful to me and the patch straightforward. I wonder why you used a global name for the max length ("_MAXCACHE") instead of inlining the value where it is used. Does it feel more constanty? ;) I fear that the leading underscore won’t discourage users from touching it, so I’d suggest making it public or completely hidden. On second thought, you could argue that Python is a matter of consenting adults, and that leading underscore is okay. Regards

Content

Hello
The feature seems useful to me and the patch straightforward.
I wonder why you used a global name for the max length ("_MAXCACHE") instead of inlining the value where it is used. Does it feel more constanty? ;) I fear that the leading underscore won’t discourage users from touching it, so I’d suggest making it public or completely hidden. On second thought, you could argue that Python is a matter of consenting adults, and that leading underscore is okay.
Regards

History
Date	User	Action	Args
2010年02月16日 05:02:13	eric.araujo	set	recipients: + eric.araujo, andrewclegg
2010年02月16日 05:02:12	eric.araujo	set	messageid: <1266296532.89.0.195780253421.issue7846@psf.upfronthosting.co.za>
2010年02月16日 05:02:10	eric.araujo	link	issue7846 messages
2010年02月16日 05:02:10	eric.araujo	create

homepage