Message98474
| Author |
flox |
| Recipients |
Trundle, amaury.forgeotdarc, brett.cannon, flox, r.david.murray |
| Date |
2010年01月28日.20:11:25 |
| SpamBayes Score |
2.3997573e-09 |
| Marked as misclassified |
No |
| Message-id |
<1264709488.41.0.791846924469.issue7732@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
> if PyFile_FromFile fails for another reason (PyString_FromString(name)
> runs out of memory), the fp is not closed and the caller is right to
> call fclose().
As far as I understand, the fp is never left open, when PyFile_FromFile returns NULL. So there's no reason to call fclose on it.
However I found a reference leak in the case you describe (PyString_FromString(name) == NULL).
It is fixed with this last update. |
|