Message 95157 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	brian.curtin
Recipients	benjamin.peterson, brian.curtin, christian.heimes
Date	2009年11月12日.05:07:21
SpamBayes Score	2.6188416e-06
Marked as misclassified	No
Message-id	<1258002447.12.0.869743215157.issue2777@psf.upfronthosting.co.za>

Content
I re-enabled the tests a few days ago and haven't seen any issues on Windows or Linux. I attached a patch against r76222 which enables the kill, term, and send_signal tests again, and also did some clean-up and updating to the way tests are skipped. I also changed the assertNotEqual at the end of the kill, term, and send_signal tests to check against None instead of 0. I think it should be checking against None there to make sure that the subprocess isn't live anymore (where None would mean that it is). Let me know what you think and if this needs anything else.

Content

I re-enabled the tests a few days ago and haven't seen any issues on
Windows or Linux. I attached a patch against r76222 which enables the
kill, term, and send_signal tests again, and also did some clean-up and
updating to the way tests are skipped.
I also changed the assertNotEqual at the end of the kill, term, and
send_signal tests to check against None instead of 0. I *think* it
should be checking against None there to make sure that the subprocess
isn't live anymore (where None would mean that it is).
Let me know what you think and if this needs anything else.

History
Date	User	Action	Args
2009年11月12日 05:07:27	brian.curtin	set	recipients: + brian.curtin, christian.heimes, benjamin.peterson
2009年11月12日 05:07:27	brian.curtin	set	messageid: <1258002447.12.0.869743215157.issue2777@psf.upfronthosting.co.za>
2009年11月12日 05:07:26	brian.curtin	link	issue2777 messages
2009年11月12日 05:07:25	brian.curtin	create

homepage