This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
| Author | pitrou |
|---|---|
| Recipients | Rhamphoryncus, giampaolo.rodola, gregory.p.smith, hgibson50, jcea, kevinwatters, pitrou, sserrano, vstinner |
| Date | 2009年11月07日.15:06:56 |
| SpamBayes Score | 0.023159057 |
| Marked as misclassified | No |
| Message-id | <0016361e86cc72961c0477c94fc0@google.com> |
| In-reply-to |
| Content | |
|---|---|
Thanks for the review. I will make the suggested modifications. http://codereview.appspot.com/150055/diff/1/4 File Modules/_threadmodule.c (right): http://codereview.appspot.com/150055/diff/1/4#newcode221 Modules/_threadmodule.c:221: return PyBool_FromLong((long) r); On 2009年11月07日 07:48:05, gregory.p.smith wrote: > This explicit (long) cast is unnecessary. Right. http://codereview.appspot.com/150055/diff/1/4#newcode246 Modules/_threadmodule.c:246: PyThread_release_lock(self->rlock_lock); On 2009年11月07日 07:48:05, gregory.p.smith wrote: > reset self->rlock_owner to 0 before releasing the lock. We always check rlock_count before rlock_owner anyway but, yes, I could reset rlock_owner out of safety. http://codereview.appspot.com/150055 |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2009年11月07日 15:06:59 | pitrou | set | recipients: + pitrou, jcea, Rhamphoryncus, hgibson50, vstinner, giampaolo.rodola, kevinwatters, sserrano |
| 2009年11月07日 15:06:57 | pitrou | link | issue3001 messages |
| 2009年11月07日 15:06:57 | pitrou | create | |