Message91033
| Author |
eric.smith |
| Recipients |
eric.smith, ezio.melotti, mark.dickinson |
| Date |
2009年07月29日.10:35:40 |
| SpamBayes Score |
4.3548175e-06 |
| Marked as misclassified |
No |
| Message-id |
<1248863742.59.0.882027983305.issue6595@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Since you're calling int() on the result, can't this code:
self._int = str(int((intpart+fracpart).lstrip('0') or '0'))
just be:
self._int = str(int(intpart+fracpart))
?
And here, you already know diag is not None, so do you need the "or '0'"
part?
self._int = str(int(diag or '0')).lstrip('0')
And, in both calls to .lstrip('0'), what happens if you have a
non-European leading '0', like '\uff10'?
Otherwise, the patch looks good to me. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2009年07月29日 10:35:43 | eric.smith | set | recipients:
+ eric.smith, mark.dickinson, ezio.melotti |
| 2009年07月29日 10:35:42 | eric.smith | set | messageid: <1248863742.59.0.882027983305.issue6595@psf.upfronthosting.co.za> |
| 2009年07月29日 10:35:40 | eric.smith | link | issue6595 messages |
| 2009年07月29日 10:35:40 | eric.smith | create |
|