Message86860
| Author |
eric.smith |
| Recipients |
amaury.forgeotdarc, eric.smith, larry, mhammond, paul.moore |
| Date |
2009年05月01日.00:33:23 |
| SpamBayes Score |
6.392664e-13 |
| Marked as misclassified |
No |
| Message-id |
<1241138006.17.0.854390578884.issue5799@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The doc patch doesn't apply cleanly for me.
There are a number of code cleanups in the patch, like 0->False,
1->True, the improvement of the params to path(), improvement in
isabs(), etc. I think these cleanups should be made in a separate patch,
so that it's easier to evaluate what's really involved in this change.
I'd be happy to do that, and produce the patches, if you could produce a
clean patch.
The docstring for splitdrive() should be indented, see PEP 257. Also,
the code snippet in that docstring is wrong, it uses 'split' where it
should be 'result', I think.
I haven't worked my way through all of the code and tests, yet. |
|