Message 84794 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	yorick
Recipients	d_kagedal, fpmc, gregory.p.smith, mkc, yorick
Date	2009年03月31日.15:00:47
SpamBayes Score	1.4469463e-06
Marked as misclassified	No
Message-id	<1238511649.1.0.831730615213.issue3392@psf.upfronthosting.co.za>

Content
The patch looks all right in general. I would use something like if "poll" in dir(select) instead of catching AttributeError which risks hiding bugs in _communicate_with_poll(). PEP8 probably wants spaces around the bitwise-or operator. Some systems cannot use TTYs in poll(2) but this should not be a problem here - there is no point in using .communicate() with stdin/ stdout/stderr set to anything but PIPE, right?

Content

The patch looks all right in general. I would use something like
if "poll" in dir(select)
instead of catching AttributeError which risks hiding bugs in 
_communicate_with_poll().
PEP8 probably wants spaces around the bitwise-or operator.
Some systems cannot use TTYs in poll(2) but this should not be a 
problem here - there is no point in using .communicate() with stdin/
stdout/stderr set to anything but PIPE, right?

History
Date	User	Action	Args
2009年03月31日 15:00:49	yorick	set	recipients: + yorick, gregory.p.smith, mkc, d_kagedal, fpmc
2009年03月31日 15:00:49	yorick	set	messageid: <1238511649.1.0.831730615213.issue3392@psf.upfronthosting.co.za>
2009年03月31日 15:00:47	yorick	link	issue3392 messages
2009年03月31日 15:00:47	yorick	create

homepage