Message83965
| Author |
loewis |
| Recipients |
collinwinter, gregory.p.smith, jcea, loewis, pitrou, rhettinger, stutzbach |
| Date |
2009年03月22日.10:20:30 |
| SpamBayes Score |
2.3493817e-06 |
| Marked as misclassified |
No |
| Message-id |
<1237717233.58.0.548038043361.issue4688@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The patch looks fine to me. Some documentation is missing, still:
is_tracked needs to be documented in the regular documentation, and
SHOW_TRACK_COUNT should be documented in SpecialBuilds.txt.
I'm not sure whether you actually want to integrate SHOW_TRACK_COUNT
into the code base. If yes, it should be cleaned up a little. There
should be no default #undef for it, and, IMO, it should count tuples, too. |
|