This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
| Author | ajaksu2 |
|---|---|
| Recipients | ajaksu2, amaury.forgeotdarc, benjamin.peterson, christian.heimes, exarkun, giampaolo.rodola, gregory.p.smith, ialbert, pitrou, rhettinger, wplappert |
| Date | 2009年03月03日.21:09:34 |
| SpamBayes Score | 0.0019890072 |
| Marked as misclassified | No |
| Message-id | <0016361649e7059a0f04643d5acd@google.com> |
| In-reply-to |
| Content | |
|---|---|
A couple of typos in the Python implementation. http://codereview.appspot.com/22061/diff/1/11 File Lib/_pyio.py (right): http://codereview.appspot.com/22061/diff/1/11#newcode266 Line 266: fp is closed after the suite of the with statment is complete: statment -> statement http://codereview.appspot.com/22061/diff/1/11#newcode844 Line 844: self._reset_read_buf() Setting "_read_buf" and "_read_pos" directly on __init__ may help introspection tools. http://codereview.appspot.com/22061/diff/1/11#newcode963 Line 963: DEAFULT_BUFFER_SIZE. If max_buffer_size is omitted, it defaults to DEAFULT_BUFFER_SIZE -> DEFAULT_BUFFER_SIZE http://codereview.appspot.com/22061/diff/1/11#newcode1728 Line 1728: decoder = self._decoder or self._get_decoder() 'decoder' isn't used in this method, is this here for an useful side-effect? http://codereview.appspot.com/22061/diff/1/11#newcode1784 Line 1784: more_line = '' This seems unused. http://codereview.appspot.com/22061 |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2009年03月03日 21:09:36 | ajaksu2 | set | recipients: + ajaksu2, rhettinger, gregory.p.smith, exarkun, amaury.forgeotdarc, giampaolo.rodola, christian.heimes, benjamin.peterson, wplappert, ialbert |
| 2009年03月03日 21:09:34 | ajaksu2 | link | issue4565 messages |
| 2009年03月03日 21:09:34 | ajaksu2 | create | |