Message82676
| Author |
lemburg |
| Recipients |
lemburg, mark.dickinson, rpetrov, vstinner |
| Date |
2009年02月24日.19:52:25 |
| SpamBayes Score |
2.8745774e-07 |
| Marked as misclassified |
No |
| Message-id |
<49A44FF8.3050102@egenix.com> |
| In-reply-to |
<1235504390.94.0.374066402211.issue4474@psf.upfronthosting.co.za> |
| Content |
On 2009年02月24日 20:39, Mark Dickinson wrote:
> Mark Dickinson <dickinsm@gmail.com> added the comment:
>
> Updated Victor's patch:
>
> - applies cleanly against newly whitespace-normalized unicodeobject.c
> - renamed USE_WCHAR_SURROGATE to CONVERT_WCHAR_TO_SURROGATES
> - add defined(SIZEOF_WCHAR_T) check
>
> I find the patched version of PyUnicode_FromWideChar quite hard to follow
> with all the #ifdefery. I wonder whether it might be better to define a
> _PyUnicode16_FromWideChar32 helper function instead.
Same here. It would be better to have a single #ifdef #else #endif
block with one branch for the CONVERT_WCHAR_TO_SURROGATES case and the
other for the normal operation.
No need for a new helper function. |
|