Message82233
| Author |
pitrou |
| Recipients |
amaury.forgeotdarc, bob.ippolito, georg.brandl, loewis, pitrou |
| Date |
2009年02月16日.12:40:34 |
| SpamBayes Score |
1.4172535e-09 |
| Marked as misclassified |
No |
| Message-id |
<1234788043.21.0.41965889062.issue4136@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
A bunch of comments from a quick look:
- why do you use old-style relative imports ("from decoder import
JSONDecoder")?
- in join_list_unicode, join_list_string you could use PyUnicode_Join
and _PyString_Join, respectively
- in scanstring_unicode, the top comment says "encoding is the encoding
of pystr (must be an ASCII superset)", but the function takes no
"encoding" parameter
- there are some lines much longer than 80 chars (it's quite clear when
reading the diff)
- there are places where you call PyObject_IsTrue(s->strict) without
checking for an error return; perhaps you could do so in the constructor
- the Scanner type doesn't support cyclic garbage collection, but it
contains some arbitrary Python objects (parse_constant and friends could
be closures or methods)
- same issue with the Encoder type (default_fn could hold arbitrary
objects alive) |
|