Message80890
| Author |
mhammond |
| Recipients |
amaury.forgeotdarc, kristjan.jonsson, loewis, mhammond |
| Date |
2009年01月31日.23:39:10 |
| SpamBayes Score |
0.00020547377 |
| Marked as misclassified |
No |
| Message-id |
<1233445152.98.0.929881174119.issue4804@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I believe your new patch suffers the same problem. Consider the blocks
like:
+ /* turn off crt asserts on windows since we have no control over fd */
+ Py_BEGIN_CRT_ERROR_HANDLING
Py_BEGIN_ALLOW_THREADS
size = write(fd, pbuf.buf, (size_t)pbuf.len);
Py_END_ALLOW_THREADS
+ Py_END_CRT_ERROR_HANDLING
And consider Martin's comments in msg80191: Here you have T1 setting a
global mode, then releasing the GIL. Other threads are then free to run
and may do the same and depending on the order the threads do things,
the global setting may not end up where it started. |
|