Message 78958 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	ajaksu2, gpolo, loewis, pitrou, vstinner
Date	2009年01月03日.14:00:12
SpamBayes Score	1.3532767e-08
Marked as misclassified	No
Message-id	<1230991215.35.0.664074846446.issue3638@psf.upfronthosting.co.za>

Content
> Tkapp_Mainloop is supposed to work both as a module function > and a method, and it tests for self to find out which > case it is. Now, this test is apparently broken in 3.x, ... Ok. In Python 2.x, selfptr is NULL whereas selfptr is a pointer to the module in Python 3.x. New attached patch uses PyModule_Check() to check if selfptr is the module or an object. > if that function is removed, the code to support > it should also be removed. Which code? I don't see which code uses _tkinter.mainloop. I saw code that calls the method mainloop() of a Tkapp object, like tkinter.mainloop() does. Or am I wrong?

Content

> Tkapp_Mainloop is supposed to work both as a module function 
> and a method, and it tests for self to find out which
> case it is. Now, this test is apparently broken in 3.x, ...
Ok. In Python 2.x, selfptr is NULL whereas selfptr is a pointer to the 
module in Python 3.x. New attached patch uses PyModule_Check() to 
check if selfptr is the module or an object.
> if that function is removed, the code to support 
> it should also be removed.
Which code? I don't see which code uses _tkinter.mainloop. I saw code 
that calls the method mainloop() of a Tkapp object, like 
tkinter.mainloop() does. Or am I wrong?

History
Date	User	Action	Args
2009年01月03日 14:00:15	vstinner	set	recipients: + vstinner, loewis, pitrou, ajaksu2, gpolo
2009年01月03日 14:00:15	vstinner	set	messageid: <1230991215.35.0.664074846446.issue3638@psf.upfronthosting.co.za>
2009年01月03日 14:00:14	vstinner	link	issue3638 messages
2009年01月03日 14:00:13	vstinner	create

homepage