Message75899
| Author |
vstinner |
| Recipients |
Neil Muller, davidfraser, hodgestar, tebeka, vstinner, werneck |
| Date |
2008年11月15日.00:33:11 |
| SpamBayes Score |
1.8906765e-11 |
| Marked as misclassified |
No |
| Message-id |
<1226709192.97.0.629434977999.issue2736@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I like the method, but I have some comments about the new method:
- datetime_totimestamp() is not well indented
- "PyObject *time" should be defined at the before the first
instruction
- why not using "if (time == NULL) return NULL;" directly instead of
using a block in case of time is not NULL?
- there are reference leaks: timetuple, timestamp and
PyFloat_FromDouble()
I wrote a similar patch before reading
add-datetime-totimestamp-method.diff which does exactly the same... I
attach my patch but both should be merged. |
|