Message75370
| Author |
christian.heimes |
| Recipients |
LambertDW, amaury.forgeotdarc, barry, christian.heimes, vstinner |
| Date |
2008年10月30日.14:15:51 |
| SpamBayes Score |
5.037526e-12 |
| Marked as misclassified |
No |
| Message-id |
<1225376155.21.0.858698372464.issue4237@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The new patch fixes the problem and adds a unit test, too.
The bug was caused by a design flaw -- which was partly my fault. Some
elements of the PyFileIOObject struct were initialized in __new__ while
other parts were initialized in __init__. I've moved the initialization
to __new__.
We should add a rule that all struct members must be properly
initialized in __new__. In the past Victor's fuzzying tool has revealed
several crashers related to similar design flaws.
I'm raising the severity of the bug to release blocker because I can't
predict if the problem can be abused to crash the interpreter. We should
also review all __new__ and __init__ methods of objects and extension
modules for similar issues. |
|