Message74443
| Author |
amaury.forgeotdarc |
| Recipients |
amaury.forgeotdarc, vstinner |
| Date |
2008年10月07日.13:05:58 |
| SpamBayes Score |
0.027750133 |
| Marked as misclassified |
No |
| Message-id |
<1223384761.41.0.362907022937.issue3975@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The patch goes in the good direction, here are some remarks:
- The two calls to open() are missing the O_BINARY flag, necessary on
Windows to avoid newline translation. This may be important for some codecs.
- the GIL should be released around calls to open(); searching the whole
sys.path can be long.
Besides this, the "char* filename" is relevant only on utf8-encoded
filesystems, and will not work on windows with non-ascii filenames. But
this is another issue. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2008年10月07日 13:06:01 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, vstinner |
| 2008年10月07日 13:06:01 | amaury.forgeotdarc | set | messageid: <1223384761.41.0.362907022937.issue3975@psf.upfronthosting.co.za> |
| 2008年10月07日 13:05:58 | amaury.forgeotdarc | link | issue3975 messages |
| 2008年10月07日 13:05:58 | amaury.forgeotdarc | create |
|