Message 74291 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	benjamin.peterson, brett.cannon, loewis, vstinner
Date	2008年10月04日.00:40:18
SpamBayes Score	2.616568e-11
Marked as misclassified	No
Message-id	<1223080821.14.0.847578753345.issue3574@psf.upfronthosting.co.za>

Content
It looks like the problem of fix_latin.diff is the decoding_state: it's set to STATE_NORMAL whereas current behaviour is to stay in state STATE_RAW. I wrote another patch which is a mix of case 1 (utf-8: just set tok->encoding) and case 2 (another charset: set tok->enc, tok->encoding and tok>decoding_state): a new case 3 which set enc, encoding but stay a the state STATE_RAW. I don't understand my patch, so review it (twice or more :-D). Using my patch: - compile(...) works - test_shlex.py works - test_pep3120.py - iso.py works

Content

It looks like the problem of fix_latin.diff is the decoding_state: 
it's set to STATE_NORMAL whereas current behaviour is to stay in state 
STATE_RAW.
I wrote another patch which is a mix of case 1 (utf-8: just set 
tok->encoding) and case 2 (another charset: set tok->enc, 
tok->encoding and tok>decoding_state): a new case 3 which set enc, 
encoding but stay a the state STATE_RAW. I don't understand my patch, 
so review it (twice or more :-D). Using my patch:
 - compile(...) works
 - test_shlex.py works
 - test_pep3120.py
 - iso.py works

History
Date	User	Action	Args
2008年10月04日 00:40:21	vstinner	set	recipients: + vstinner, loewis, brett.cannon, benjamin.peterson
2008年10月04日 00:40:21	vstinner	set	messageid: <1223080821.14.0.847578753345.issue3574@psf.upfronthosting.co.za>
2008年10月04日 00:40:19	vstinner	link	issue3574 messages
2008年10月04日 00:40:19	vstinner	create

homepage