Message73739
| Author |
theller |
| Recipients |
effbot, mgiuca, skip.montanaro, theller, tim.maxwell |
| Date |
2008年09月24日.18:01:32 |
| SpamBayes Score |
1.5851212e-05 |
| Marked as misclassified |
No |
| Message-id |
<48DA807B.3000807@ctypes.org> |
| In-reply-to |
<1222277775.01.0.919360028984.issue3547@psf.upfronthosting.co.za> |
| Content |
Skip Montanaro schrieb:
> Looks reasonable, though I'm no ctypes maven. Trivial little nit:
> In the comment just before the start of CField_FromDesc it says,
> in part:
>
> * Expects the size, index and offset for the current field in *psize and
> * *poffset, stores the total size so far in *psize, the offset for the next
>
> Note that it identifies three values (size, index, offset) as stored
> in two locations (*psize and *poffset). Seems like some sort of
> mismatch to me.
Unfortunately this is not the only comment that is out of date in the
ctypes sources. I wanted to touch as little code as possible in this patch.
Thanks. |
|