Message73738
| Author |
theller |
| Recipients |
effbot, mgiuca, skip.montanaro, theller, tim.maxwell |
| Date |
2008年09月24日.18:00:26 |
| SpamBayes Score |
1.6438812e-06 |
| Marked as misclassified |
No |
| Message-id |
<48DA803A.4010901@ctypes.org> |
| In-reply-to |
<1222277438.3.0.659553640907.issue3547@psf.upfronthosting.co.za> |
| Content |
Fredrik Lundh schrieb:
> Looks fine to me, except for the comment in the test suite. Should
>
> + # MS compilers do NOT combine c_short and c_int into
> + # one field, gcc doesn't.
>
> perhaps be
>
> + # MS compilers do NOT combine c_short and c_int into
> + # one field, gcc do.
Sure. But isn't this correct (or better) english, instead?
^^^^
> Is using explicit tests for MSVC vs. GCC a good idea, btw? What about
> other compilers? Can the test be changed to accept either value?
Well, MSVC and GCC are the only compilers that I use (and that are tested
on the buildbots, afaik). If a cygwin compiled Python, for example, fails
this test then of course the test must be changed.
Thanks. |
|