Message73535
| Author |
amaury.forgeotdarc |
| Recipients |
HWJ, amaury.forgeotdarc, benjamin.peterson, dlitz, gvanrossum, pitrou, vstinner, zegreek |
| Date |
2008年09月21日.22:05:39 |
| SpamBayes Score |
0.00288653 |
| Marked as misclassified |
No |
| Message-id |
<1222034740.83.0.0991565008983.issue3187@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I did not test the patch, but I have some remarks about it:
- %r does not seem to be handled by PyUnicode_FromFormat; %R maybe?
- In this case, PyObject_Repr(v) is not necessary - and this will avoid
a reference leak.
- Does the warning warn multiple times? IIRC the default behaviour is to
warn once. |
|