Message70562
| Author |
pitrou |
| Recipients |
amaury.forgeotdarc, barry, benjamin.peterson, donmez, giampaolo.rodola, gpolo, loewis, pitrou, teoliphant |
| Date |
2008年08月01日.15:46:24 |
| SpamBayes Score |
0.015378112 |
| Marked as misclassified |
No |
| Message-id |
<1217605582.48932fce9282b@imp.free.fr> |
| In-reply-to |
<1217604214.72.0.370472763481.issue3139@psf.upfronthosting.co.za> |
| Content |
Selon "Martin v. Löwis" <report@bugs.python.org>:
>
> As for making Py_buffer own a reference to the object: what should be
> the semantics for PyObject_ReleaseBuffer? I see the following options:
> - Drop PyObject_ReleaseBuffer
> - make it DECREF the embedded object, whether or not it is the same as
> the object being passed in
> - leave it as-is, and require the caller to DECREF.
I don't know, is there supposed to be a semantic difference between
PyObject_ReleaseBuffer and PyBuffer_Release? If not, I'd say drop it.
Also, I think it's fine if you commit your fix without adding an incref/decref.
In the absence of the designer of the buffer API it is difficult to know what
subtleties should be taken into account when trying to change that API... |
|