This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
| Author | collinwinter |
|---|---|
| Recipients | brett.cannon, collinwinter, nedds, orsenthil |
| Date | 2008年07月10日.17:42:31 |
| SpamBayes Score | 0.027967433 |
| Marked as misclassified | No |
| Message-id | <1215711755.02.0.696809410412.issue3316@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
- You should add tests to test_fixers to ensure that this does what you
expect. This will make it much easier for others to modify this fixer
later. You can probably just reuse the tests Brett initially added.
- There's a better data structure for MAPPING: rather than using
MAPPING = {module: [(new_module, [member, member, ..., member])]}
you should probably use
MAPPING = {module: {new_module: [member, member, ..., member]}}
The list-of-2-tuples was a bad idea on my part that didn't scale.
- The "cannot handle star imports" warning isn't strictly correct: star
imports for robotparser and urlparse can both be handled correctly,
since they're just being renamed.
- urlparse and robotparser don't seem to belong to this more specialized
fixer: they can go in fix_imports, since they aren't being broken across
multiple modules. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2008年07月10日 17:42:35 | collinwinter | set | spambayes_score: 0.0279674 -> 0.027967433 recipients: + collinwinter, brett.cannon, orsenthil, nedds |
| 2008年07月10日 17:42:35 | collinwinter | set | spambayes_score: 0.0279674 -> 0.0279674 messageid: <1215711755.02.0.696809410412.issue3316@psf.upfronthosting.co.za> |
| 2008年07月10日 17:42:34 | collinwinter | link | issue3316 messages |
| 2008年07月10日 17:42:32 | collinwinter | create | |