Message 69419 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	alanmcintyre
Recipients	alanmcintyre, amaury.forgeotdarc, loewis
Date	2008年07月08日.08:46:36
SpamBayes Score	0.0011190595
Marked as misclassified	No
Message-id	<1215506797.63.0.361625061556.issue3317@psf.upfronthosting.co.za>

Content
The patch seems to work just fine for me, all tests pass (including test_zipfile64) on an Intel Mac. I'd vote to go ahead and revert the magicXXX variables back to their original names--I'm sure Twisted isn't the only project out there that made use of them. If the magicXXX name change gets checked in along with the current patch I'll run the zip64 tests on Mac and Linux afterward, since they don't get run in the standard test run on the buildbots. I don't currently have a Windows machine to test with.

Content

The patch seems to work just fine for me, all tests pass (including
test_zipfile64) on an Intel Mac. I'd vote to go ahead and revert the
magicXXX variables back to their original names--I'm sure Twisted isn't
the only project out there that made use of them.
If the magicXXX name change gets checked in along with the current patch
I'll run the zip64 tests on Mac and Linux afterward, since they don't
get run in the standard test run on the buildbots. I don't currently
have a Windows machine to test with.

History
Date	User	Action	Args
2008年07月08日 08:46:37	alanmcintyre	set	spambayes_score: 0.00111906 -> 0.0011190595 recipients: + alanmcintyre, loewis, amaury.forgeotdarc
2008年07月08日 08:46:37	alanmcintyre	set	spambayes_score: 0.00111906 -> 0.00111906 messageid: <1215506797.63.0.361625061556.issue3317@psf.upfronthosting.co.za>
2008年07月08日 08:46:36	alanmcintyre	link	issue3317 messages
2008年07月08日 08:46:36	alanmcintyre	create

homepage