Message 69051 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	collinwinter
Recipients	collinwinter, nedds
Date	2008年07月01日.17:15:59
SpamBayes Score	0.001218959
Marked as misclassified	No
Message-id	<1214932561.05.0.439601786586.issue3218@psf.upfronthosting.co.za>

Content
The change to pytree.py doesn't add much speed benefit over the fix_imports.py change, and causes a test to fail. The fix_imports.py change, on the other hand, takes the test suite run time from 8m31s down to 1m45s -- this needs to go in! That said, I don't think the change is correct: you remove the portion of the pattern that matches "from foo import bar, baz, x, y as z", as well as the portion that matches "foo.bar" in the body of the code, where foo is a module to be renamed. These should be added back, but with support for member matching removed.

Content

The change to pytree.py doesn't add much speed benefit over the
fix_imports.py change, and causes a test to fail.
The fix_imports.py change, on the other hand, takes the test suite run
time from 8m31s down to 1m45s -- this needs to go in!
That said, I don't think the change is correct: you remove the portion
of the pattern that matches "from foo import bar, baz, x, y as z", as
well as the portion that matches "foo.bar" in the body of the code,
where foo is a module to be renamed. These should be added back, but
with support for member matching removed.

History
Date	User	Action	Args
2008年07月01日 17:16:01	collinwinter	set	spambayes_score: 0.00121896 -> 0.001218959 recipients: + collinwinter, nedds
2008年07月01日 17:16:01	collinwinter	set	spambayes_score: 0.00121896 -> 0.00121896 messageid: <1214932561.05.0.439601786586.issue3218@psf.upfronthosting.co.za>
2008年07月01日 17:16:00	collinwinter	link	issue3218 messages
2008年07月01日 17:15:59	collinwinter	create

homepage