Message 68173 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	Rhamphoryncus
Recipients	Rhamphoryncus, amaury.forgeotdarc, jnoller
Date	2008年06月13日.18:32:21
SpamBayes Score	0.007917994
Marked as misclassified	No
Message-id	<1213381945.72.0.0851603980727.issue3100@psf.upfronthosting.co.za>

Content
Well, my attempt at a patch didn't work, and yours does, so I guess I have to support yours. ;) Can you review my python-incref-from-zero patch? It verifies the invariant that you need, that once an object hits a refcount of 0 it won't get raised again. (The possibility of __del__ makes me worry, but it looks okay.) gcmodule.c has an inline copy of handle_callbacks. Is it possible a collection could have the same problem we're fixing here? Minor nit: you're asserting cbcalled, but you're not using the generic callback, so it's meaningless.

Content

Well, my attempt at a patch didn't work, and yours does, so I guess I
have to support yours. ;)
Can you review my python-incref-from-zero patch? It verifies the
invariant that you need, that once an object hits a refcount of 0 it
won't get raised again. (The possibility of __del__ makes me worry, but
it *looks* okay.)
gcmodule.c has an inline copy of handle_callbacks. Is it possible a
collection could have the same problem we're fixing here?
Minor nit: you're asserting cbcalled, but you're not using the generic
callback, so it's meaningless.

History
Date	User	Action	Args
2008年06月13日 18:32:26	Rhamphoryncus	set	spambayes_score: 0.00791799 -> 0.007917994 recipients: + Rhamphoryncus, amaury.forgeotdarc, jnoller
2008年06月13日 18:32:25	Rhamphoryncus	set	spambayes_score: 0.00791799 -> 0.00791799 messageid: <1213381945.72.0.0851603980727.issue3100@psf.upfronthosting.co.za>
2008年06月13日 18:32:24	Rhamphoryncus	link	issue3100 messages
2008年06月13日 18:32:22	Rhamphoryncus	create

homepage