Message 65831 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	belopolsky
Recipients	amaury.forgeotdarc, belopolsky, benjamin.peterson, georg.brandl, gvanrossum, pitrou, rhettinger
Date	2008年04月26日.00:22:41
SpamBayes Score	0.09262578
Marked as misclassified	No
Message-id	<1209169362.85.0.16672131774.issue2603@psf.upfronthosting.co.za>

Content
With respect to range_eq8_normalize2.patch, it is unusual to have a function that consumes a reference to its argument. I would combine normalize_stop with PyNumber_Index and make it similar to validate_step with respect to reference counting. Note that if you choose stop = start + len*step normaization, you will not need to create 'one' in normalize_stop. With your patch I see >>> range(0,6,2) range(0, 6, 2) >>> range(0,5,2) range(0, 5, 2) I would expect one of these ranges normalized.

Content

With respect to range_eq8_normalize2.patch, it is unusual to have a 
function that consumes a reference to its argument. I would combine 
normalize_stop with PyNumber_Index and make it similar to validate_step 
with respect to reference counting.
Note that if you choose stop = start + len*step normaization, you will 
not need to create 'one' in normalize_stop.
With your patch I see
>>> range(0,6,2)
range(0, 6, 2)
>>> range(0,5,2)
range(0, 5, 2)
I would expect one of these ranges normalized.

History
Date	User	Action	Args
2008年04月26日 00:22:43	belopolsky	set	spambayes_score: 0.0926258 -> 0.09262578 recipients: + belopolsky, gvanrossum, georg.brandl, rhettinger, amaury.forgeotdarc, pitrou, benjamin.peterson
2008年04月26日 00:22:42	belopolsky	set	spambayes_score: 0.0926258 -> 0.0926258 messageid: <1209169362.85.0.16672131774.issue2603@psf.upfronthosting.co.za>
2008年04月26日 00:22:42	belopolsky	link	issue2603 messages
2008年04月26日 00:22:41	belopolsky	create

homepage