Message 65816 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	amaury.forgeotdarc
Recipients	amaury.forgeotdarc, belopolsky, benjamin.peterson, georg.brandl, gvanrossum, pitrou, rhettinger
Date	2008年04月25日.21:57:44
SpamBayes Score	0.020945558
Marked as misclassified	No
Message-id	<1209160668.96.0.077281338739.issue2603@psf.upfronthosting.co.za>

Content
about range_eq7.patch: - Did you change your mind about range equality? range(0,10,2) == range(0,9,2) seems True now; it was not with range_eq6.patch - The hash function will fail with big values (and wrongly returns a value even when an exception is set). I suggest to call PyObject_Hash instead of PyNumber_AsSsize_t. - Now that you short-circuit the comparison, it is enough to have only one boolean variable (is_equal), which may replace all uses of start_same, stop_same and step_same.

Content

about range_eq7.patch:
- Did you change your mind about range equality?
 range(0,10,2) == range(0,9,2)
seems True now; it was not with range_eq6.patch
- The hash function will fail with big values (and wrongly returns a
value even when an exception is set). I suggest to call PyObject_Hash
instead of PyNumber_AsSsize_t.
- Now that you short-circuit the comparison, it is enough to have only
one boolean variable (is_equal), which may replace all uses of
start_same, stop_same and step_same.

History
Date	User	Action	Args
2008年04月25日 21:57:50	amaury.forgeotdarc	set	spambayes_score: 0.0209456 -> 0.020945558 recipients: + amaury.forgeotdarc, gvanrossum, georg.brandl, rhettinger, belopolsky, pitrou, benjamin.peterson
2008年04月25日 21:57:49	amaury.forgeotdarc	set	spambayes_score: 0.0209456 -> 0.0209456 messageid: <1209160668.96.0.077281338739.issue2603@psf.upfronthosting.co.za>
2008年04月25日 21:57:47	amaury.forgeotdarc	link	issue2603 messages
2008年04月25日 21:57:46	amaury.forgeotdarc	create

homepage