Message 65678 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	trent
Recipients	benjamin.peterson, loewis, trent
Date	2008年04月22日.19:03:22
SpamBayes Score	0.023312252
Marked as misclassified	No
Message-id	<1208891004.93.0.858082922461.issue2440@psf.upfronthosting.co.za>

Content
Update: the changes committed on r62269 and r62279 were incorrect and reverted in r62292. Log: Issue 2440: revert r62269 and r62279. These changes were made in an effort to fix test_args2.Signed_TestCase.test_n(), which was failing on Windows x64 on the following line: 'self.failUnlessEqual(99, getargs_n (Long()))'. Although the two commits did fix the test on Windows x64, it's become clear that it's the test that's incorrect, and the changes to PyNumber_Index() in particular were not warranted (and actually violate PEP 357). This commit will get us back to where we were at r62268, before I started butchering things. The reworked patch fixes test_getargs2.py, such that it verifies Long() and Int() can't be used as indexes. It also fixes the handling of 'n' in getargs.c's convertsimple(). Committed in r62462.

Content

Update: the changes committed on r62269 and r62279 were incorrect and 
reverted in r62292.
Log:
Issue 2440: revert r62269 and r62279. These changes were made in an 
effort to fix test_args2.Signed_TestCase.test_n(), which was failing on 
Windows x64 on the following line: 'self.failUnlessEqual(99, getargs_n
(Long()))'. Although the two commits *did* fix the test on Windows 
x64, it's become clear that it's the test that's incorrect, and the 
changes to PyNumber_Index() in particular were not warranted (and 
actually violate PEP 357). This commit will get us back to where we 
were at r62268, before I started butchering things.
The reworked patch fixes test_getargs2.py, such that it verifies Long() 
and Int() can't be used as indexes. It also fixes the handling of 'n' 
in getargs.c's convertsimple(). Committed in r62462.

History
Date	User	Action	Args
2008年04月22日 19:03:25	trent	set	spambayes_score: 0.0233123 -> 0.023312252 recipients: + trent, loewis, benjamin.peterson
2008年04月22日 19:03:25	trent	set	spambayes_score: 0.0233123 -> 0.0233123 messageid: <1208891004.93.0.858082922461.issue2440@psf.upfronthosting.co.za>
2008年04月22日 19:03:23	trent	link	issue2440 messages
2008年04月22日 19:03:22	trent	create

homepage